-
Notifications
You must be signed in to change notification settings - Fork 66
guix: fix package defenition #389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
I am not sure that vulkan-headers are required. (replace 'build (lambda _ (invoke "cmake" "--build" ".")))
(replace 'install (lambda _ (invoke "cmake" "--install" ".")))Also it seems like build phases that are in package do no changes at all and can be removed. Please confirm if so, I'll fix both this issues. |
|
If it builds fine with all features enabled, and qtdeclarative modules are still available in the environment this seems fine. Unless I'm reading it wrong you're not actually adding polkit to the deps list though, and I'm not sure why you moved wayland-protocols. Removing those replacements should also be fine if it still builds. |
polkit was already in the dependency list, the issue was that package wasn't importing the Guix module that provides its package definition. I added that.
Regarding wayland-protocols, you're right, moving it was a mistake on my part. |
I did remove replacements, it still builds fine:
I don't really understand how Qt works at all so I don't really know a way to test that. |
|
Running quickshell with example config in pure shell works fine. Maybe that can prove it works? |
|
If it works in a pure shell that's probably enough |
Changes:
After last change to quickshell.scm with addition of polkit, module for polkit wasn't added.
I found that many inputs were in wrong places, some of them even repeated. Also bash-minimal should be added since we wrap binary.
This caused errors like so when using as a channel:
and
Result:
Setup:
Using upstream repo as a channel:
Using my PR's repo as a channel: