Skip to content

Add the ability to set the key_prefix and group_name options for Dagster assets, drop support for Python 3.8 and 3.9 #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JulesHuisman merged 2 commits into from
Aug 6, 2025
Merged

Add the ability to set the key_prefix and group_name options for Dagster assets, drop support for Python 3.8 and 3.9 #36

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
94b47be
Add the ability to set the key_prefix and grou_name options for Dagst…
guusfrenken-wk Jul 4, 2025
dd12ddc
Drop support for Python 3.8 and 3.9
guusfrenken-wk Aug 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,10 @@ jobs:
fail-fast: false
matrix:
python:
- "3.8"
- "3.9"
- "3.10"
- "3.11"
- "3.12"
- "3.13"

steps:
- name: Check out repository code
Expand Down
4 changes: 3 additions & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,6 @@ __pycache__/
.env
tap-*.json
tmp*
.ignore/
.ignore/
.idea
.venv
9 changes: 7 additions & 2 deletions elx/extensions/dagster/assets.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,12 +20,17 @@
def load_assets(
runner: Runner,
deps: Iterable[AssetKey | str | Sequence[str] | AssetsDefinition | SourceAsset | AssetDep] | None = None,
key_prefix: str | Sequence[str] | None = None,
group_name: str | None = None,
) -> List[AssetsDefinition]:
"""
Load the assets for a runner, each asset represents one tap target combination.

Args:
runner (Runner): The runner to extract from.
deps (Iterable[AssetKey | str | Sequence[str] | AssetsDefinition | SourceAsset | AssetDep] | None): Upstream assets upon which the assets depend.
key_prefix (str | Sequence[str] | None): Key prefix for the assets. If not provided, defaults to the tap executable name.
group_name (str | None): Group name for the assets. If not provided, defaults to the tap executable name.

Returns:
List[AssetsDefinition]: The assets.
Expand Down Expand Up @@ -78,14 +83,14 @@ def run(context: OpExecutionContext) -> Generator[Output, None, None]:
dagster_safe_name(stream.name): AssetOut(
is_required=False,
description=generate_description(runner=runner, stream=stream),
key_prefix=dagster_safe_name(runner.tap.executable),
key_prefix=key_prefix or dagster_safe_name(runner.tap.executable),
code_version=runner.tap.hash_key,
)
for stream in runner.tap.catalog.streams
if stream.is_selected
},
can_subset=True,
group_name=dagster_safe_name(runner.tap.executable),
group_name=group_name or dagster_safe_name(runner.tap.executable),
compute_kind="python",
)(run_factory(runner))
]
Loading
Loading