test #15: throw exception if not dot found in the file name

Author: chfw

tests/test_upload_n_download_excel.py

@@ -50,13 +50,29 @@ def test_download(self):
                                      file_content=response.data)
                 sheet.format(int)
                 array = sheet.to_array()
-                assert array == self.data
+                eq_(array, self.data)
+
+    def test_no_file_type(self):
+        file_name = 'issue15'
+        download_file_type = "xls"
+        io = pe.save_as(dest_file_type="xls",
+                        array=self.data)
+        if not PY2:
+            if not isinstance(io, BytesIO):
+                io = BytesIO(io.getvalue().encode('utf-8'))
+        response = self.app.post(
+            '/switch/%s' % download_file_type,
+            buffered=True,
+            data={"file": (io, file_name)},
+            content_type="multipart/form-data")
+        eq_(response.content_type, 'text/html')
+        eq_(response.status_code, 400)
 
     def test_override_file_name(self):
         for file_type in FILE_TYPE_MIME_TABLE.keys():
             file_name = 'override_file_name'
             response = self.app.post('/file_name/%s/%s' % (file_type,
                                                            file_name))
-            assert response.content_type == FILE_TYPE_MIME_TABLE[file_type]
-            assert response.headers.get("Content-Disposition", None) == (
-                    "attachment; filename=%s.%s" % (file_name, file_type))
+            eq_(response.content_type, FILE_TYPE_MIME_TABLE[file_type])
+            eq_(response.headers.get("Content-Disposition", None),
+                ("attachment; filename=%s.%s" % (file_name, file_type)))

tests/testapp.py

@@ -1,4 +1,4 @@
-from flask import Flask, request, jsonify
+from flask import Flask, request, jsonify, abort
 from flask.ext import excel
 import pyexcel as pe
 from flask.ext.sqlalchemy import SQLAlchemy
@@ -75,8 +75,11 @@ def respond_array(struct_type):
 
 @app.route("/switch/<file_type>", methods=['POST'])
 def switch(file_type):
-    sheet = request.get_sheet(field_name='file')
-    return excel.make_response(sheet, file_type)
+    try:
+        sheet = request.get_sheet(field_name='file')
+        return excel.make_response(sheet, file_type)
+    except IOError:
+        abort(400)
 
 
 @app.route("/file_name/<file_type>/<file_name>", methods=['POST'])