Add provider_url to ModelResponse and use it in cost()
#3648
+502
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mahiro72
commented
Dec 7, 2025
| def base_url(self) -> str: | ||
| assert self._url is not None, 'URL not initialized' # pragma: no cover | ||
| return self._url # pragma: no cover | ||
| assert self._url is not None, 'URL not initialized' |
Author
There was a problem hiding this comment.
[note]
This change now calls this property to retrieve provider_url, so it's now covered by tests.
Removing # pragma: no cover.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
provider_urlfield toModelResponseto store the provider's API endpoint URLprovider_urltocalc_price()asprovider_api_urlfor more accurate pricing calculationsprovider_urlabstract property toStreamedResponseand implement it in all subclassesCloses #3608