Spa.julian day microsecond fix (#942)

* Fixes microsecond scaling issue in spa.julian_day_dt, and updates the test in tests_spa to check for correct scaling

Author: ericf900

docs/sphinx/source/whatsnew/v0.7.2.rst

@@ -48,6 +48,8 @@ Bug fixes
   and various test functions.
 * Fix :py:func:`~pvlib.iotools.read_tmy3` so that when coerced to a single year
   the TMY3 index will be monotonically increasing. (:pull:`910`)
+* Fix :py:func:`pvlib.spa.julian_day_dt` so that microseconds are scaled
+  correctly (:issue:`940`) (:pull:`942`)
 
 Testing
 ~~~~~~~

pvlib/spa.py

@@ -430,7 +430,7 @@ def julian_day_dt(year, month, day, hour, minute, second, microsecond):
         month = month+12
     a = int(year/100)
     b = 2 - a + int(a * 0.25)
-    frac_of_day = (microsecond + (second + minute * 60 + hour * 3600)
+    frac_of_day = (microsecond / 1e6 + (second + minute * 60 + hour * 3600)
                    ) * 1.0 / (3600*24)
     d = day + frac_of_day
     jd = (int(365.25 * (year + 4716)) + int(30.6001 * (month + 1)) + d +

pvlib/tests/test_spa.py

@@ -98,15 +98,16 @@
 class SpaBase(object):
     """Test functions common to numpy and numba spa"""
     def test_julian_day_dt(self):
-        dt = times.tz_convert('UTC')[0]
+        # add 1us manually to the test timestamp (GH #940)
+        dt = times.tz_convert('UTC')[0] + pd.Timedelta(1, unit='us')
         year = dt.year
         month = dt.month
         day = dt.day
         hour = dt.hour
         minute = dt.minute
         second = dt.second
         microsecond = dt.microsecond
-        assert_almost_equal(JD,
+        assert_almost_equal(JD + 1e-6 / (3600*24),  # modify expected JD by 1us
                             self.spa.julian_day_dt(
                                 year, month, day, hour,
                                 minute, second, microsecond), 6)