Commit 2a436c6
ENH: implementing pvsyst recombination loss current for CdTe and a:Si (#504)
* implementing pvsyst recombination loss current for CdTe and a:Si
* closes #163
* add constant VOLTAGE_BUILTIN = 0.9 (V) to singlediode_methods.py
* add arguments d2mutau=0, voltage_builtin=VOLTAGE_BUILTIN, and
cells_in_series to calculate i_recomb and v_recomb
* add check for d2mutau to calc i_recomb, v_recomb, and gradients
* add terms to current and gradients
* ENH: need to set grad_i_recomb if d2mutau not given
* also set v_recomb to Inf, so that 1/v_recomb is always zero
* but precalculate grad_2i_recomb only if d2mutau > 0, otherwise, use
zero
* ENH: fix need to multiply vbi by Ns, add test for recombination
* WIP: ENH: TST: BUG: in test compare desoto vs. pvsyst
* ENH: respond to comments
* change order of bishop88 args: cells_in_series to be first before
d2mutau and voltage_builtin
* hardcode PVSYST_FS495 coefficients
* don't compare pvsyst to desoto, instead compare pvsyst to fixed values
at two conditions: reference and 888[W/m^2],55[degC]
* rename test to be agnostic to module SKU
* remove testing script if __name__ == '__main__': section, not for
release
* DOC: ENH: update bishop88 documentation for pvsyst thin-film recombination loss
* DOC: ENH: update what's new
* DOC: add utf-8 file encoding
* DOC: ENH: BUG: minor doc fixes and formatting
* need to indent bullets in warning
* only need cells in series for PVSyst thin-film recombination loss
* escape math latex twice inside docstrings without raw prefix, eg:
\\tau without extra escape is a tab character, ha ha ha
* in rst, italics is a single asterisk, not underscore, thats markdown
* ENH: improve code style, fix d2mutau is array
* expand module type abbrev. in warnings
* also expand EG to For example, too terse
* cells in series can be int _or_ `None`
* since d2mutau and vbi are arrays, then ambiguous to test for zero, so
use np.where to assign conditionally instead (in two places)
* ENH: TST: use fixture instead of module-level dictionary for test
* dangerous to use module-level dictionary inside test, b/c dictionary
values could be changed inadvertently, but not a fixture
* add fixture as argument in test
* change parametrize to call fixture instead of module-level dictionary
* ENH: replace voltage_builtin with NsVbi and remove cells_in_series
* related to #516, the use of cells_in_series here is problematic
* to calculate arrays of different cells or modules with different
parameters we use np.where(is_recomb, ..., ...) 3d0deb2 but what
should cells_in_series be if d2mutau is zero? doesn't make physical
sense for it to be zero, but None doesn't work with numbers
* remove cells_in_series arg from bishop88
* remove last warning about setting cells_in_series correctly, move it
to Notes, but worded differently in the context of setting NsVbi
* replace voltage_builtin with NsVbi, default to np.inf
* fix docstring parameter descriptions1 parent f57f4c6 commit 2a436c6
File tree
3 files changed
+132
-9
lines changed- docs/sphinx/source/whatsnew
- pvlib
- test
3 files changed
+132
-9
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
58 | 58 | | |
59 | 59 | | |
60 | 60 | | |
| 61 | + | |
61 | 62 | | |
62 | 63 | | |
63 | 64 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
1 | 2 | | |
2 | 3 | | |
3 | 4 | | |
| |||
22 | 23 | | |
23 | 24 | | |
24 | 25 | | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
25 | 29 | | |
26 | 30 | | |
27 | 31 | | |
| |||
62 | 66 | | |
63 | 67 | | |
64 | 68 | | |
65 | | - | |
| 69 | + | |
| 70 | + | |
66 | 71 | | |
67 | 72 | | |
68 | | - | |
| 73 | + | |
69 | 74 | | |
70 | | - | |
71 | | - | |
72 | | - | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
73 | 79 | | |
74 | 80 | | |
75 | 81 | | |
| |||
86 | 92 | | |
87 | 93 | | |
88 | 94 | | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
89 | 103 | | |
90 | 104 | | |
91 | 105 | | |
| |||
96 | 110 | | |
97 | 111 | | |
98 | 112 | | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
99 | 140 | | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
100 | 145 | | |
101 | 146 | | |
102 | 147 | | |
103 | 148 | | |
104 | | - | |
| 149 | + | |
105 | 150 | | |
106 | 151 | | |
107 | 152 | | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
108 | 156 | | |
109 | | - | |
| 157 | + | |
110 | 158 | | |
111 | 159 | | |
112 | 160 | | |
113 | 161 | | |
114 | | - | |
| 162 | + | |
115 | 163 | | |
116 | 164 | | |
117 | 165 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
| 7 | + | |
| 8 | + | |
7 | 9 | | |
8 | 10 | | |
9 | 11 | | |
| |||
100 | 102 | | |
101 | 103 | | |
102 | 104 | | |
103 | | - | |
| 105 | + | |
104 | 106 | | |
105 | 107 | | |
106 | 108 | | |
| |||
125 | 127 | | |
126 | 128 | | |
127 | 129 | | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
| 191 | + | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
| 197 | + | |
| 198 | + | |
| 199 | + | |
| 200 | + | |
| 201 | + | |
0 commit comments