fix and re-enable planet orders download checksum test

Author: jreiberkyle

tests/integration/test_orders_cli.py

@@ -258,13 +258,13 @@ def _func():
 
         order_description['_links']['results'] = [{
             'location': dl_url1,
-            'name': 'oid/itemtype/m1.json'
+            'name': f'{oid}/itemtype/m1.json'
         }, {
             'location': dl_url2,
-            'name': 'oid/itemtype/m2.json'
+            'name': f'{oid}/itemtype/m2.json'
         }, {
             'location': dl_url3,
-            'name': 'oid/manifest.json'
+            'name': f'{oid}/manifest.json'
         }]  # yapf: disable
 
         get_url = f'{TEST_ORDERS_URL}/{oid}'
@@ -334,32 +334,22 @@ def test_cli_orders_download_default(invoke, mock_download_response, oid):
         assert 'm1.json' in result.output
 
         # Check that the files were downloaded and have the correct contents
-        with open(Path(folder) / 'oid/itemtype/m1.json') as f:
+        with open(Path(folder) / f'{oid}/itemtype/m1.json') as f:
             assert json.load(f) == {'key': 'value'}
-        with open(Path(folder) / 'oid/itemtype/m2.json') as f:
+        with open(Path(folder) / f'{oid}/itemtype/m2.json') as f:
             assert json.load(f) == {'key2': 'value2'}
 
 
 @respx.mock
-@pytest.mark.skip("""does not actually test checksum, copy of
-test_cli_orders_download_default""")
 def test_cli_orders_download_checksum(invoke, mock_download_response, oid):
+    '''checksum is successful'''
     mock_download_response()
 
     runner = CliRunner()
-    with runner.isolated_filesystem() as folder:
-        result = invoke(['download', oid], runner=runner)
+    with runner.isolated_filesystem():
+        result = invoke(['download', oid, '--checksum=MD5'], runner=runner)
         assert result.exit_code == 0
 
-        # basic check of progress reporting
-        assert 'm1.json' in result.output
-
-        # Check that the files were downloaded and have the correct contents
-        with open(Path(folder) / 'oid/itemtype/m1.json') as f:
-            assert json.load(f) == {'key': 'value'}
-        with open(Path(folder) / 'oid/itemtype/m2.json') as f:
-            assert json.load(f) == {'key2': 'value2'}
-
 
 @respx.mock
 def test_cli_orders_download_dest(invoke, mock_download_response, oid):
@@ -374,10 +364,10 @@ def test_cli_orders_download_dest(invoke, mock_download_response, oid):
         assert result.exit_code == 0
 
         # Check that the files were downloaded to the custom directory
-        with open(dest_dir / 'oid/itemtype/m1.json') as f:
+        with open(dest_dir / f'{oid}/itemtype/m1.json') as f:
             assert json.load(f) == {'key': 'value'}
 
-        with open(dest_dir / 'oid/itemtype/m2.json') as f:
+        with open(dest_dir / f'{oid}/itemtype/m2.json') as f:
             assert json.load(f) == {'key2': 'value2'}
 
 
@@ -390,7 +380,7 @@ def test_cli_orders_download_overwrite(invoke,
 
     runner = CliRunner()
     with runner.isolated_filesystem() as folder:
-        filepath = Path(folder) / 'oid/itemtype/m1.json'
+        filepath = Path(folder) / f'{oid}/itemtype/m1.json'
         filepath.parent.mkdir(parents=True)
         filepath.write_text(json.dumps({'foo': 'bar'}))