use dash instead of underscore in all cases

Author: charcey

docs/cli/cli-orders.md

@@ -236,7 +236,7 @@ planet orders request \
     --name 'My First Order' \
     20220605_124027_64_242b \
     --hosting sentinel_hub \
-    --collection_id ba8f7274-aacc-425e-8a38-e21517bfbeff
+    --collection-id ba8f7274-aacc-425e-8a38-e21517bfbeff
 ```
 
 ```
@@ -246,12 +246,12 @@ planet orders request \
     --name 'My First Order' \
     20220605_124027_64_242b \
     --hosting sentinel_hub \
-    --create_configuration
+    --create-configuration
 ```
 
 - The --hosting option is optional and currently supports sentinel_hub as its only value.
-- The --collection_id is also optional. If you decide to use this, ensure that the order request and the collection have matching bands. If you're unsure, allow the system to create a new collection for you by omitting the --collection_id option. This will ensure the newly set-up collection is configured correctly, and you can subsequently add items to this collection as needed.
-- The --create_configuration option will create a new [layer configuration](https://apps.sentinel-hub.com/dashboard/#/configurations) in Sentinel Hub on your behalf. This option cannot be used with --collection_id.
+- The --collection-id is also optional. If you decide to use this, ensure that the order request and the collection have matching bands. If you're unsure, allow the system to create a new collection for you by omitting the --collection-id option. This will ensure the newly set-up collection is configured correctly, and you can subsequently add items to this collection as needed.
+- The --create-configuration option will create a new [layer configuration](https://apps.sentinel-hub.com/dashboard/#/configurations) in Sentinel Hub on your behalf. This option cannot be used with --collection-id.
 
 For more information on Sentinel Hub hosting, see the [Orders API documentation](https://developers.planet.com/apis/orders/delivery/#delivery-to-sentinel-hub-collection) and the [Linking Planet User to Sentinel Hub User
 ](https://support.planet.com/hc/en-us/articles/16550358397469-Linking-Planet-User-to-Sentinel-Hub-User) support post.
@@ -318,18 +318,18 @@ if you run that command again it will create a second order).
 
 #### Sentinel Hub Hosting
 
-For convenience, `planet orders create` accepts the same `--hosting`, `--collection_id`, and `--create_configuration` options that [`planet orders request`](#sentinel-hub-hosting) does.
+For convenience, `planet orders create` accepts the same `--hosting`, `--collection-id`, and `--create-configuration` options that [`planet orders request`](#sentinel-hub-hosting) does.
 
 ```sh
 planet orders create request-1.json \
     --hosting sentinel_hub \
-    --collection_id ba8f7274-aacc-425e-8a38-e21517bfbeff
+    --collection-id ba8f7274-aacc-425e-8a38-e21517bfbeff
 ```
 
 ```sh
 planet orders create request-1.json \
     --hosting sentinel_hub \
-    --create_configuration
+    --create-configuration
 ```
 
 ### Create Request and Order in One Call

docs/cli/cli-subscriptions.md

@@ -541,8 +541,8 @@ planet subscriptions request \
 When creating a new subscription, you can include hosting options directly using the --hosting, --collection-id, and --create-configuration flags.
 
 - The --hosting option is optional and currently supports sentinel_hub as its only value.
-- The --collection_id is also optional. If you decide to use this, ensure that the subscription request and the collection have matching bands. If you're unsure, allow the system to create a new collection for you by omitting the --collection_id option. This will ensure the newly set-up collection is configured correctly, and you can subsequently add items to this collection as needed.
-- The --create_configuration option will create a new [layer configuration](https://apps.sentinel-hub.com/dashboard/#/configurations) in Sentinel Hub on your behalf. This option cannot be used with --collection_id.
+- The --collection-id is also optional. If you decide to use this, ensure that the subscription request and the collection have matching bands. If you're unsure, allow the system to create a new collection for you by omitting the --collection-id option. This will ensure the newly set-up collection is configured correctly, and you can subsequently add items to this collection as needed.
+- The --create_configuration option will create a new [layer configuration](https://apps.sentinel-hub.com/dashboard/#/configurations) in Sentinel Hub on your behalf. This option cannot be used with --collection-id.
 - You may also input --hosting as a JSON file. The file should be formatted:
 
 ```sh

planet/cli/orders.py

@@ -370,7 +370,7 @@ async def create(ctx, request, pretty, **kwargs):
               type=click.Choice(['sentinel_hub']),
               help='Hosting for data delivery. '
               'Currently, only "sentinel_hub" is supported.')
-@click.option('--collection_id',
+@click.option('--collection-id',
               help='Collection ID for Sentinel Hub hosting. '
               'If omitted, a new collection will be created.')
 @click.option(

tests/integration/test_orders_cli.py

@@ -826,7 +826,7 @@ def test_cli_orders_request_hosting_sentinel_hub_collection_id(
         '--name=test',
         '20220325_131639_20_2402',
         '--hosting=sentinel_hub',
-        '--collection_id=1234'
+        '--collection-id=1234'
     ])
 
     order_request = {
@@ -859,7 +859,7 @@ def test_cli_orders_request_hosting_sentinel_hub_create_configuration(
         '--name=test',
         '20220325_131639_20_2402',
         '--hosting=sentinel_hub',
-        '--create_configuration'
+        '--create-configuration'
     ])
 
     order_request = {
@@ -892,8 +892,8 @@ def test_cli_orders_request_hosting_sentinel_hub_collection_configuration(
         '--name=test',
         '20220325_131639_20_2402',
         '--hosting=sentinel_hub',
-        '--collection_id=1234',
-        '--create_configuration'
+        '--collection-id=1234',
+        '--create-configuration'
     ])
 
     order_request = {

tests/integration/test_subscriptions_cli.py

@@ -467,10 +467,10 @@ def test_catalog_source_time_range_type(invoke, geom_geojson, time_range_type):
          "--collection-id=7ff105c4-e0de-4910-96db-8345d86ab734",
          None,
          True),
-        ("--hosting=sentinel_hub", None, "--create_configuration", True),
+        ("--hosting=sentinel_hub", None, "--create-configuration", True),
         ("--hosting=sentinel_hub",
          "--collection-id=7ff105c4-e0de-4910-96db-8345d86ab734",
-         "--create_configuration",
+         "--create-configuration",
          True),
     ])
 def test_request_hosting(invoke,