Don't sum non-numbers from PHP 8.3 onwards

NorthNick · NorthNick · commit b58e5c41c5fc · 2024-10-21T08:32:13.000+01:00
diff --git a/tests/Map/sum.php b/tests/Map/sum.php
@@ -5,6 +5,7 @@ trait sum
 {
     public function sumDataProvider()
     {
+        $nonNumbers = version_compare(PHP_VERSION, '8.3.0', '>=') ? [true, false, null] : ["a", true, false, null];
         return [
 
             // Empty
@@ -23,7 +24,7 @@ public function sumDataProvider()
             [["2", "5", "10.5"], 17.5],
 
             // Non-numbers
-            [["a", true, false, null], 1],
+            [$nonNumbers, 1],
         ];
     }
 
diff --git a/tests/Sequence/sum.php b/tests/Sequence/sum.php
@@ -5,6 +5,7 @@ trait sum
 {
     public function sumDataProvider()
     {
+        $nonNumbers = version_compare(PHP_VERSION, '8.3.0', '>=') ? [true, false, null] : ["a", true, false, null];
         return [
 
             // Empty
@@ -23,7 +24,7 @@ public function sumDataProvider()
             [["2", "5", "10.5"], 17.5],
 
             // Non-numbers
-            [["a", true, false, null], 1],
+            [$nonNumbers, 1],
         ];
     }
 
diff --git a/tests/Set/sum.php b/tests/Set/sum.php
@@ -5,6 +5,7 @@ trait sum
 {
     public function sumDataProvider()
     {
+        $nonNumbers = version_compare(PHP_VERSION, '8.3.0', '>=') ? [true, false, null] : ["a", true, false, null];
         return [
 
             // Empty
@@ -23,7 +24,7 @@ public function sumDataProvider()
             [["2", "5", "10.5"], 17.5],
 
             // Non-numbers
-            [["a", true, false, null], 1],
+            [$nonNumbers, 1],
         ];
     }
 

Original file line number	Diff line number	Diff line change
`@@ -5,6 +5,7 @@ trait sum`
`5`	`5`	`{`
`6`	`6`	`public function sumDataProvider()`
`7`	`7`	`{`
	`8`	`+ $nonNumbers = version_compare(PHP_VERSION, '8.3.0', '>=') ? [true, false, null] : ["a", true, false, null];`
`8`	`9`	`return [`
`9`	`10`
`10`	`11`	`// Empty`
`@@ -23,7 +24,7 @@ public function sumDataProvider()`
`23`	`24`	`[["2", "5", "10.5"], 17.5],`
`24`	`25`
`25`	`26`	`// Non-numbers`
`26`		`- [["a", true, false, null], 1],`
	`27`	`+ [$nonNumbers, 1],`
`27`	`28`	`];`
`28`	`29`	`}`
`29`	`30`