Changed Util::find() to use the "find" command when no arguments are specified.

(This significantly improves performance in typical use cases, compared to processing a "print .proplist=.id" collection)

Author: boenrobot

src/PEAR2/Net/RouterOS/Util.php

@@ -297,13 +297,11 @@ public function find()
     {
         if (func_num_args() === 0) {
             if (null === $this->idCache) {
-                $idCache = array();
-                foreach ($this->client->sendSync(
-                    new Request($this->menu . '/print .proplist=.id')
-                )->getAllOfType(Response::TYPE_DATA) as $response) {
-                    $idCache[] = $response->getArgument('.id');
-                }
-                $this->idCache = $idCache;
+               $idCache = $this->client->sendSync(
+                   new Request($this->menu . '/find')
+               )->getArgument('ret');
+               $this->idCache = explode(',', $idCache);
+               return $idCache;
             }
             return implode(',', $this->idCache);
         }

tests/UtilStateAlteringFeaturesTest.php

@@ -68,7 +68,7 @@ public function testAdd()
      * 
      * @return void
      */
-    public function testAddToCache()
+    public function testAddUpdatingCache()
     {
         $this->util->changeMenu('/queue/simple');
         $beforeCount = substr_count($this->util->find(), ',');