Doc fixes;

Removed default values wherever the value is unconditionally set by the constructor.

Author: boenrobot

src/PEAR2/Net/RouterOS/Client.php

@@ -247,7 +247,7 @@ private static function _login(
      * Sets the charset(s) for this connection. The specified charset(s) will be
      * used for all future requests and responses. When sending,
      * {@link Communicator::CHARSET_LOCAL} is converted to
-     * {@link Communicator::HARSET_REMOTE}, and when receiving,
+     * {@link Communicator::CHARSET_REMOTE}, and when receiving,
      * {@link Communicator::CHARSET_REMOTE} is converted to
      * {@link Communicator::CHARSET_LOCAL}. Setting NULL to either charset will
      * disable charset convertion, and data will be both sent and received "as

src/PEAR2/Net/RouterOS/Communicator.php

@@ -408,9 +408,9 @@ protected static function verifyLengthSupport($length)
     /**
      * Encodes the length as requred by the RouterOS API.
      * 
-     * @param int $length The length to encode
+     * @param int $length The length to encode.
      * 
-     * @return string The encoded length
+     * @return string The encoded length.
      */
     public static function encodeLength($length)
     {
@@ -520,7 +520,7 @@ public function getNextWordAsStream()
      * @param T\Stream $trans The transmitter from which to decode the length of
      * the incoming message.
      * 
-     * @return int The decoded length
+     * @return int The decoded length.
      */
     public static function decodeLength(T\Stream $trans)
     {
@@ -545,7 +545,7 @@ public static function decodeLength(T\Stream $trans)
      * @param T\Stream $trans The transmitter from which to decode the length of
      * the incoming message.
      * 
-     * @return int The decoded length
+     * @return int The decoded length.
      */
     private static function _decodeLength(T\Stream $trans)
     {

src/PEAR2/Net/RouterOS/LengthException.php

@@ -34,24 +34,24 @@ class LengthException extends \LengthException implements Exception
 
     /**
      *
-     * @var mixed The unsuppported value.
+     * @var mixed The problematic length.
      */
-    private $_length = null;
+    private $_length;
 
     /**
      * Creates a new LengthException.
      * 
-     * @param string    $message  The Exception message to throw.
-     * @param int       $code     The Exception code.
-     * @param Exception $previous The previous exception used for the exception
+     * @param string     $message  The Exception message to throw.
+     * @param int        $code     The Exception code.
+     * @param \Exception $previous The previous exception used for the exception
      * chaining.
-     * @param number    $value    The length.
+     * @param number     $length    The length.
      */
     public function __construct($message, $code = 0, $previous = null,
-        $value = null
+        $length = null
     ) {
         parent::__construct($message, $code, $previous);
-        $this->_length = $value;
+        $this->_length = $length;
     }
 
     /**
@@ -74,7 +74,7 @@ public function getLength()
      */
     public function __toString()
     {
-        return parent::__toString() . "\nValue:{$this->_length}";
+        return parent::__toString() . "\nLength:{$this->_length}";
     }
 
     // @codeCoverageIgnoreEnd

src/PEAR2/Net/RouterOS/NotSupportedException.php

@@ -37,16 +37,16 @@ class NotSupportedException extends \Exception implements Exception
      *
      * @var mixed The unsuppported value.
      */
-    private $_value = null;
+    private $_value;
 
     /**
      * Creates a new NotSupportedException.
      * 
-     * @param string    $message  The Exception message to throw.
-     * @param int       $code     The Exception code.
-     * @param Exception $previous The previous exception used for the exception
+     * @param string     $message  The Exception message to throw.
+     * @param int        $code     The Exception code.
+     * @param \Exception $previous The previous exception used for the exception
      * chaining.
-     * @param mixed     $value    The unsupported value.
+     * @param mixed      $value    The unsupported value.
      */
     public function __construct($message, $code = 0, $previous = null,
         $value = null

src/PEAR2/Net/RouterOS/Request.php

@@ -45,7 +45,7 @@ class Request extends Message
     /**
      * @var Query A query for the command.
      */
-    private $_query = null;
+    private $_query;
 
     /**
      * Creates a request to send to RouterOS.

src/PEAR2/Net/RouterOS/Response.php

@@ -20,6 +20,9 @@
  */
 namespace PEAR2\Net\RouterOS;
 
+/**
+ * Refers to transmitter direction constants.
+ */
 use PEAR2\Net\Transmitter as T;
 
 /**
@@ -63,7 +66,7 @@ class Response extends Message
     /**
      * @var string The response type.
      */
-    private $_type = null;
+    private $_type;
 
     /**
      * Extracts a new response from a communicator.

src/PEAR2/Net/RouterOS/UnexpectedValueException.php

@@ -37,7 +37,7 @@ class UnexpectedValueException extends \UnexpectedValueException
      *
      * @var mixed The unexpected value.
      */
-    private $_value = null;
+    private $_value;
 
     /**
      * Creates a new UnexpectedValueException.