Skip to content
This repository was archived by the owner on Sep 13, 2020. It is now read-only.

Commit 9af5938

Browse files
author
Damian Kowalewski
committed
use memset to make sure we get a null terminated strings
1 parent fbc34d6 commit 9af5938

File tree

1 file changed

+16
-16
lines changed

1 file changed

+16
-16
lines changed

unix/yun/yun.c

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -40,44 +40,44 @@ int yunReadProvisioningInfo() {
4040
char value[64];
4141
if ((socketHandle = tcp_connect("localhost", 5700)) > 0) {
4242
// read appId
43-
buf[0] = '\0';
44-
value[0] = '\0';
43+
memset(buf, 0, sizeof(buf));
44+
memset(value, 0, sizeof(value));
4545
tcp_write(socketHandle, "{\"command\": \"get\", \"key\": \"appId\"}\n");
46-
if (tcp_read(socketHandle, buf, 128, 2)) {
47-
getValueFromJSON(buf, "value", value, 64);
46+
if (tcp_read(socketHandle, buf, sizeof(buf) - 1, 2)) {
47+
getValueFromJSON(buf, "value", value, sizeof(value));
4848
if(strcmp("null", value) != 0) {
4949
strncpy(g_cAppID, value, sizeof(g_cAppID));
5050
}
5151
}
5252

5353
// read clientKey
54-
buf[0] = '\0';
55-
value[0] = '\0';
54+
memset(buf, 0, sizeof(buf));
55+
memset(value, 0, sizeof(value));
5656
tcp_write(socketHandle, "{\"command\": \"get\", \"key\": \"clientKey\"}\n");
57-
if (tcp_read(socketHandle, buf, 128, 2)) {
58-
getValueFromJSON(buf, "value", value, 64);
57+
if (tcp_read(socketHandle, buf, sizeof(buf) - 1, 2)) {
58+
getValueFromJSON(buf, "value", value, sizeof(value));
5959
if(strcmp("null", value) != 0) {
6060
strncpy(g_cClientKey, value, sizeof(g_cClientKey));
6161
}
6262
}
6363

6464
// read installationId
65-
buf[0] = '\0';
66-
value[0] = '\0';
65+
memset(buf, 0, sizeof(buf));
66+
memset(value, 0, sizeof(value));
6767
tcp_write(socketHandle, "{\"command\": \"get\", \"key\": \"installationId\"}\n");
68-
if (tcp_read(socketHandle, buf, 128, 2)) {
69-
getValueFromJSON(buf, "value", value, 64);
68+
if (tcp_read(socketHandle, buf, sizeof(buf) - 1, 2)) {
69+
getValueFromJSON(buf, "value", value, sizeof(value));
7070
if(strcmp("null", value) != 0) {
7171
strncpy(g_cInstallationID, value, sizeof(g_cInstallationID));
7272
}
7373
}
7474

7575
// read sessionToken
76-
buf[0] = '\0';
77-
value[0] = '\0';
76+
memset(buf, 0, sizeof(buf));
77+
memset(value, 0, sizeof(value));
7878
tcp_write(socketHandle, "{\"command\": \"get\", \"key\": \"sessionToken\"}\n");
79-
if (tcp_read(socketHandle, buf, 128, 2)) {
80-
getValueFromJSON(buf, "value", value, 64);
79+
if (tcp_read(socketHandle, buf, sizeof(buf) - 1, 2)) {
80+
getValueFromJSON(buf, "value", value, sizeof(value));
8181
if(strcmp("null", value) != 0) {
8282
strncpy(g_cSessionToken, value, sizeof(g_cSessionToken));
8383
}

0 commit comments

Comments
 (0)