[new-clone] remove extraneous parameters in clone sample

Author: Pavan Kumar

add_cmd_test.go

@@ -58,7 +58,7 @@ func newAddCmdHarnessWithConfig(t testing.TB) (*Harness, *addCmd, error) {
 	h, _ := newAddCmdHarness(t)
 	h.makeEmptyRoot()
 
-	ensure.Nil(t, (&newCmd{}).cloneSampleCloudCode(h.env, &app{Name: "B"}, false, true))
+	ensure.Nil(t, (&newCmd{}).cloneSampleCloudCode(h.env, true))
 
 	return h, &a, nil
 }
@@ -115,7 +115,7 @@ func newLegacyAddCmdHarnessWithConfig(t testing.TB) (*Harness, *addCmd, error) {
 	h, _ := newAddCmdHarness(t)
 	h.makeEmptyRoot()
 
-	ensure.Nil(t, (&newCmd{}).cloneSampleCloudCode(h.env, &app{Name: "B"}, false, true))
+	ensure.Nil(t, (&newCmd{}).cloneSampleCloudCode(h.env, true))
 	ensure.Nil(t, os.MkdirAll(filepath.Join(h.env.Root, configDir), 0755))
 	ensure.Nil(t,
 		ioutil.WriteFile(

config_test.go

@@ -27,7 +27,7 @@ func TestConfigFromDirFormatType(t *testing.T) {
 	h.makeEmptyRoot()
 	defer h.Stop()
 
-	ensure.Nil(t, (&newCmd{}).cloneSampleCloudCode(h.env, &app{Name: "test"}, false, true))
+	ensure.Nil(t, (&newCmd{}).cloneSampleCloudCode(h.env, true))
 
 	c, err := configFromDir(h.env.Root)
 	ensure.Nil(t, err)

configure_cmd_test.go

@@ -125,7 +125,7 @@ func TestProjectType(t *testing.T) {
 	defer h.Stop()
 
 	h.makeEmptyRoot()
-	ensure.Nil(t, (&newCmd{}).cloneSampleCloudCode(h.env, &app{Name: "test"}, false, false))
+	ensure.Nil(t, (&newCmd{}).cloneSampleCloudCode(h.env, false))
 
 	c := &configureCmd{}
 	err := c.projectType(h.env, []string{"1", "2"})

default_cmd_test.go

@@ -27,7 +27,7 @@ func newDefaultCmdHarness(t testing.TB) (*Harness, *defaultCmd, *parseConfig) {
 	h := newHarness(t)
 	h.makeEmptyRoot()
 
-	ensure.Nil(t, (&newCmd{}).cloneSampleCloudCode(h.env, &app{Name: "test"}, false, true))
+	ensure.Nil(t, (&newCmd{}).cloneSampleCloudCode(h.env, true))
 
 	config := newDefaultParseConfig(t, h)
 	h.Out.Reset()
@@ -97,7 +97,7 @@ func newLegacyDefaultCmdHarness(t testing.TB) (*Harness, *defaultCmd, *parseConf
 	h := newHarness(t)
 	h.makeEmptyRoot()
 
-	ensure.Nil(t, (&newCmd{}).cloneSampleCloudCode(h.env, &app{Name: "test"}, false, true))
+	ensure.Nil(t, (&newCmd{}).cloneSampleCloudCode(h.env, true))
 	ensure.Nil(t, os.MkdirAll(filepath.Join(h.env.Root, configDir), 0755))
 	ensure.Nil(t, ioutil.WriteFile(filepath.Join(h.env.Root, legacyConfigFile),
 		[]byte("{}"),

jssdk_cmd_test.go

@@ -44,7 +44,7 @@ func newJsSdkHarnessWithConfig(t testing.TB) (*Harness, *context) {
 	h := newJsSdkHarness(t)
 	h.makeEmptyRoot()
 
-	ensure.Nil(t, (&newCmd{}).cloneSampleCloudCode(h.env, &app{Name: "test"}, false, true))
+	ensure.Nil(t, (&newCmd{}).cloneSampleCloudCode(h.env, true))
 	h.Out.Reset()
 
 	c, err := configFromDir(h.env.Root)

list_cmd_test.go

@@ -67,6 +67,6 @@ func TestPrintListNoApps(t *testing.T) {
 	h.makeEmptyRoot()
 	defer h.Stop()
 	n := &newCmd{}
-	n.cloneSampleCloudCode(h.env, &app{Name: "test"}, false, true)
+	n.cloneSampleCloudCode(h.env, true)
 	ensure.Nil(t, l.printListOfApps(h.env))
 }

new.go

@@ -237,7 +237,7 @@ This will download Cloud Code to a temporary location.
 			}
 		}
 		dumpTemplate = (isNew || dumpTemplate) && !n.noCode
-		return dumpTemplate, n.cloneSampleCloudCode(e, app, isNew, dumpTemplate)
+		return dumpTemplate, n.cloneSampleCloudCode(e, dumpTemplate)
 	}
 	return false, stackerr.Newf("Unknown project type: %d", e.Type)
 }

new_cmd.go

@@ -8,7 +8,7 @@ import (
 	"github.com/facebookgo/stackerr"
 )
 
-func (n *newCmd) cloneSampleCloudCode(e *env, app *app, isNew bool, dumpTemplate bool) error {
+func (n *newCmd) cloneSampleCloudCode(e *env, dumpTemplate bool) error {
 	err := os.MkdirAll(e.Root, 0755)
 	if err != nil {
 		return stackerr.Wrap(err)

new_cmd_test.go

@@ -24,7 +24,7 @@ func TestNewCmdDirs(t *testing.T) {
 	h, n := newNewCmdHarness(t)
 	defer h.Stop()
 
-	ensure.Nil(t, n.cloneSampleCloudCode(h.env, &app{Name: "test"}, false, true))
+	ensure.Nil(t, n.cloneSampleCloudCode(h.env, true))
 
 	var err error
 
@@ -40,7 +40,7 @@ func TestNewCmdContent(t *testing.T) {
 	h, n := newNewCmdHarness(t)
 	defer h.Stop()
 
-	ensure.Nil(t, n.cloneSampleCloudCode(h.env, &app{Name: "test"}, false, true))
+	ensure.Nil(t, n.cloneSampleCloudCode(h.env, true))
 
 	for _, newProjectFile := range newProjectFiles {
 		content, err := ioutil.ReadFile(