[tests] add more tests to improve coverage

Author: Pavan Kumar

apps.go

@@ -248,7 +248,7 @@ func (a *apps) createApp(e *env, givenName string) (*app, error) {
 		}
 
 		if _, ok := appNames[appName]; ok {
-			fmt.Fprintf(e.Out,
+			fmt.Fprintf(e.Err,
 				`Hey! you already created an app named %q.
 The apps associated with your account:
 %s

apps_test.go

@@ -259,6 +259,20 @@ RevokeSessionOnPasswordChange	true
 `)
 }
 
+func TestCreateNewAppNameTaken(t *testing.T) {
+	t.Parallel()
+
+	h, _ := newAppHarness(t)
+	defer h.Stop()
+
+	a := defaultApps
+
+	h.env.In = ioutil.NopCloser(strings.NewReader("A\nD"))
+	_, err := a.createApp(h.env, "")
+	ensure.Nil(t, err)
+	ensure.StringContains(t, h.Err.String(), "already created an app")
+}
+
 func TestNoPanicAppCreate(t *testing.T) {
 	t.Parallel()
 	h := newHarness(t)

list_cmd_test.go

@@ -1,6 +1,8 @@
 package main
 
 import (
+	"io/ioutil"
+	"strings"
 	"testing"
 
 	"github.com/facebookgo/ensure"
@@ -70,3 +72,15 @@ func TestPrintListNoApps(t *testing.T) {
 	n.cloneSampleCloudCode(h.env, true)
 	ensure.Nil(t, l.printListOfApps(h.env))
 }
+
+func TestRunListCmd(t *testing.T) {
+	t.Parallel()
+
+	h, _ := newAppHarness(t)
+	defer h.Stop()
+
+	l := &listCmd{}
+	h.env.In = ioutil.NopCloser(strings.NewReader("email\npassword\n"))
+	ensure.Nil(t, l.run(h.env, []string{"A"}))
+	ensure.StringContains(t, h.Out.String(), `Properties of the app "A"`)
+}

main_test.go

@@ -10,6 +10,7 @@ import (
 	"os"
 	"path/filepath"
 	"regexp"
+	"strings"
 	"testing"
 
 	"github.com/facebookgo/clock"
@@ -375,3 +376,31 @@ func TestMultiErrorString(t *testing.T) {
 	ensure.StringContains(t, errStr, `parse: api error with code=1 and message="message"`)
 	ensure.StringContains(t, errStr, ".go")
 }
+
+func TestRunWithContext(t *testing.T) {
+	t.Parallel()
+
+	h := newHarness(t)
+	h.makeEmptyRoot()
+	defer h.Stop()
+
+	n := &newCmd{}
+	h.env.Type = parseFormat
+	h.env.In = ioutil.NopCloser(strings.NewReader("\n"))
+	_, err := n.setupSample(h.env,
+		"yolo",
+		&parseAppConfig{
+			ApplicationID: "yolo-id",
+			MasterKey:     "yoda",
+		},
+		false,
+		false,
+	)
+	ensure.Nil(t, err)
+
+	dummy := func(e *env, c *context) error {
+		ensure.DeepEqual(t, c.AppConfig.getApplicationID(), "yolo-id")
+		return nil
+	}
+	runWithAppClient(h.env, dummy)
+}

migrate_cmd_test.go

@@ -1,7 +1,11 @@
 package main
 
 import (
+	"io/ioutil"
+	"os"
+	"path/filepath"
 	"regexp"
+	"strings"
 	"testing"
 
 	"github.com/facebookgo/ensure"
@@ -76,3 +80,51 @@ func TestUpgradeLegacyWithEmail(t *testing.T) {
 	ensure.DeepEqual(t, config.Applications["app"].MasterKey, "")
 	ensure.DeepEqual(t, config.getProjectConfig().ParserEmail, "test@email.com")
 }
+
+func TestRunMigrateCmd(t *testing.T) {
+	t.Parallel()
+
+	h := newHarness(t)
+	h.makeEmptyRoot()
+	defer h.Stop()
+
+	n := &newCmd{}
+	h.env.Type = parseFormat
+	h.env.In = ioutil.NopCloser(strings.NewReader("\n"))
+	_, err := n.setupSample(h.env,
+		"yolo",
+		&parseAppConfig{
+			ApplicationID: "yolo-id",
+			MasterKey:     "yoda",
+		},
+		false,
+		false,
+	)
+	ensure.Nil(t, err)
+
+	m := &migrateCmd{}
+	err = m.run(h.env)
+	ensure.Err(t, err, regexp.MustCompile("Already using the preferred config format"))
+
+	ensure.Nil(t, os.Remove(filepath.Join(h.env.Root, parseLocal)))
+	ensure.Nil(t, os.Remove(filepath.Join(h.env.Root, parseProject)))
+
+	ensure.Nil(t, os.MkdirAll(filepath.Join(h.env.Root, configDir), 0755))
+	ensure.Nil(t,
+		ioutil.WriteFile(
+			filepath.Join(h.env.Root, legacyConfigFile),
+			[]byte(`{
+			"applications": {
+				"yolo": {
+					"applicationId": "yolo-id",
+					"masterKey": "yoda"
+				}
+			}
+		}`),
+			0600,
+		),
+	)
+
+	ensure.Nil(t, m.run(h.env))
+	ensure.StringContains(t, h.Out.String(), "Successfully migrated")
+}

symbols_cmd_test.go

@@ -0,0 +1,18 @@
+package main
+
+import (
+	"regexp"
+	"testing"
+
+	"github.com/facebookgo/ensure"
+)
+
+func TestRunSymbolsCmd(t *testing.T) {
+	t.Parallel()
+
+	h := newHarness(t)
+	defer h.Stop()
+
+	s := &symbolsCmd{}
+	ensure.Err(t, s.run(h.env, nil), regexp.MustCompile("Please specify path"))
+}