added a another case to overlays to account hide the 'don't save' button. closes #247

Author: urbantumbleweed

src/constants/overlay-states.js

@@ -9,6 +9,7 @@ const overlayStates = {
   OVERWRITE_OVERLAY: 'OVERWRITE_OVERLAY',
   NEW_VERSION_OVERLAY: 'NEW_VERSION_OVERLAY',
   DELETE_FILE_OVERLAY: 'DELETE_FILE_OVERLAY',
+  SAVE_ON_CHANGE_OVERLAY: 'SAVE_ON_CHANGE_OVERLAY',
   DELETE_PROJECT_OVERLAY: 'DELETE_PROJECT_OVERLAY'
 };
 

src/creators/show-save-overlay.js

@@ -5,14 +5,16 @@ const {
 } = require('../constants/action-types');
 
 const {
-  SAVE_OVERLAY
+  SAVE_OVERLAY,
+  SAVE_ON_CHANGE_OVERLAY
 } = require('../constants/overlay-states');
 
-function showSaveOverlay(){
+function showSaveOverlay(showDontSaveButton){
+  const state = showDontSaveButton ? SAVE_ON_CHANGE_OVERLAY : SAVE_OVERLAY;
   return {
     type: SHOW_OVERLAY,
     payload: {
-      state: SAVE_OVERLAY
+      state
     }
   };
 }

src/plugins/handlers.js

@@ -98,7 +98,7 @@ function handlers(app, opts, done){
     // TODO: DRY this up
     if(isNew && _.trim(content).length){
       store.dispatch(creators.queueNewFile());
-      showSaveOverlay();
+      showSaveOverlay(false);
       return;
     }
 
@@ -114,7 +114,7 @@ function handlers(app, opts, done){
     const { filename, content, isNew, cwd } = workspace.getState();
 
     if(isNew){
-      showSaveOverlay();
+      showSaveOverlay(false);
     } else {
       workspace.saveFile(filename, content)
         .then(function(){
@@ -185,7 +185,7 @@ function handlers(app, opts, done){
     // TODO: DRY this up
     if(isNew && _.trim(content).length){
       store.dispatch(creators.queueChangeFile(filename));
-      showSaveOverlay();
+      showSaveOverlay(true);
       return;
     }
 

src/plugins/overlays.js

@@ -22,6 +22,7 @@ const {
   OVERWRITE_OVERLAY,
   NEW_VERSION_OVERLAY,
   DELETE_FILE_OVERLAY,
+  SAVE_ON_CHANGE_OVERLAY,
   DELETE_PROJECT_OVERLAY
 } = require('../constants/overlay-states');
 
@@ -47,6 +48,9 @@ function overlays(app, opts, done){
       case SAVE_OVERLAY:
         renderOverlay(<SaveOverlay workspace={workspace} handlers={handlers} />);
         break;
+      case SAVE_ON_CHANGE_OVERLAY:
+        renderOverlay(<SaveOverlay workspace={workspace} handlers={handlers} showDontSaveButton={true} />);
+        break;
       case OVERWRITE_OVERLAY:
         renderOverlay(<OverwriteOverlay store={store} handlers={handlers} />);
         break;

src/views/save-overlay.js

@@ -106,7 +106,7 @@ class SaveOverlay extends React.Component {
     const { filename } = this.state;
 
     let dontSaveButton;
-    if(isNew){
+    if(isNew && this.props.showDontSaveButton){
       dontSaveButton = (
         <Button onClick={this.dontSave}>Don't Save</Button>
       );