Skip to content

Commit 11185ff

Browse files
committed
value_counts, crosstab
1 parent 2c0ca6e commit 11185ff

File tree

3 files changed

+14
-10
lines changed

3 files changed

+14
-10
lines changed

pandas-stubs/__init__.pyi

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,7 @@ from pandas.core.arrays.sparse import SparseDtype as SparseDtype
6969
from pandas.core.computation.api import eval as eval
7070
from pandas.core.reshape.api import (
7171
concat as concat,
72+
crosstab as crosstab,
7273
from_dummies as from_dummies,
7374
get_dummies as get_dummies,
7475
lreshape as lreshape,
@@ -80,9 +81,6 @@ from pandas.core.reshape.api import (
8081
qcut as qcut,
8182
wide_to_long as wide_to_long,
8283
)
83-
from pandas.core.reshape.api import (
84-
crosstab as crosstab, # pyright: ignore[reportUnknownVariableType]
85-
)
8684
from pandas.core.reshape.api import (
8785
cut as cut, # pyright: ignore[reportUnknownVariableType]
8886
)

pandas-stubs/core/reshape/pivot.pyi

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ from pandas._typing import (
2828
Label,
2929
Scalar,
3030
ScalarT,
31+
SequenceNotStr,
3132
np_ndarray,
3233
)
3334

@@ -121,11 +122,14 @@ def pivot(
121122
columns: _NonIterableHashable | Sequence[HashableT2] = ...,
122123
values: _NonIterableHashable | Sequence[HashableT3] = ...,
123124
) -> DataFrame: ...
125+
126+
_Values: TypeAlias = SequenceNotStr[Any] | _ExtendedAnyArrayLike
127+
124128
@overload
125129
def crosstab(
126-
index: list | _ExtendedAnyArrayLike | list[Sequence | _ExtendedAnyArrayLike],
127-
columns: list | _ExtendedAnyArrayLike | list[Sequence | _ExtendedAnyArrayLike],
128-
values: list | _ExtendedAnyArrayLike,
130+
index: _Values | list[_Values],
131+
columns: _Values | list[_Values],
132+
values: _Values,
129133
rownames: list[HashableT1] | None = ...,
130134
colnames: list[HashableT2] | None = ...,
131135
*,
@@ -137,8 +141,8 @@ def crosstab(
137141
) -> DataFrame: ...
138142
@overload
139143
def crosstab(
140-
index: list | _ExtendedAnyArrayLike | list[Sequence | _ExtendedAnyArrayLike],
141-
columns: list | _ExtendedAnyArrayLike | list[Sequence | _ExtendedAnyArrayLike],
144+
index: _Values | list[_Values],
145+
columns: _Values | list[_Values],
142146
values: None = None,
143147
rownames: list[HashableT1] | None = ...,
144148
colnames: list[HashableT2] | None = ...,

tests/extension/decimal/array.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -345,10 +345,12 @@ def convert_values(param: Any) -> ExtensionArray | list[Any]:
345345

346346
def value_counts(self, dropna: bool = True) -> Series:
347347
from pandas.core.algorithms import ( # type: ignore[attr-defined] # isort: skip
348-
value_counts, # pyright: ignore[reportAttributeAccessIssue]
348+
value_counts, # pyright: ignore[reportAttributeAccessIssue,reportAttributeAccessIssue]
349349
)
350350

351-
return value_counts(self.to_numpy(), dropna=dropna)
351+
return value_counts(
352+
self.to_numpy(), dropna=dropna
353+
) # pyright: ignore[reportUnknownVariableType]
352354

353355

354356
DecimalArray._add_arithmetic_ops()

0 commit comments

Comments
 (0)