[GR-22669] Fix S3 dispatch with missing argument

(cherry picked from commit ec20f94)

Author: steve-s

CHANGELOG.md

@@ -25,6 +25,7 @@ New features:
 
 Bug fixes:
 
+* S3 dispatch with missing arguments, e.g., `as_tibble()` (reported by Michael Hall on Slack)
 * `dyn.load` did not work with relative paths
 * missing warnings on integer overflow #136
 * the f2c script fixed to handle extra dotted file extensions #143

com.oracle.truffle.r.nodes.builtin/src/com/oracle/truffle/r/nodes/builtin/base/S3DispatchFunctions.java

@@ -14,7 +14,7 @@
  * Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
  *
  * Copyright (c) 2014, Purdue University
- * Copyright (c) 2014, 2019, Oracle and/or its affiliates
+ * Copyright (c) 2014, 2020, Oracle and/or its affiliates
  *
  * All rights reserved.
  */
@@ -241,7 +241,7 @@ private static Object getFirstNonMissingArg(VirtualFrame frame, int startIdx) {
         }
 
         private static Object getFirstVarArg(RArgsValuesAndNames varArgs) {
-            return varArgs.isEmpty() ? null : varArgs.getArgument(0);
+            return varArgs.isEmpty() ? RNull.instance : varArgs.getArgument(0);
         }
     }
 

com.oracle.truffle.r.test/src/com/oracle/truffle/r/test/ExpectedTestOutput.test

@@ -95111,6 +95111,56 @@ NULL
 foo.c1
 foo.c1
 
+##com.oracle.truffle.r.test.functions.TestS3Dispatch.runRSourceTests#
+#{ source("tmptest/S3/missingAsNULL1.R") }
+[[1]]
+[[1]]$overload
+[1] "NULL"
+
+[[1]]$x_missing
+[1] TRUE
+
+[[1]]$args
+list()
+
+
+[[2]]
+[[2]]$overload
+[1] "NULL"
+
+[[2]]$x_missing
+[1] FALSE
+
+[[2]]$args
+list()
+
+
+
+##com.oracle.truffle.r.test.functions.TestS3Dispatch.runRSourceTests#
+#{ source("tmptest/S3/missingAsNULL2.R") }
+$first_missing
+$first_missing$overload
+[1] "bar"
+
+$first_missing$x_missing
+[1] TRUE
+
+$first_missing$y_missing
+[1] FALSE
+
+
+$all_missing
+$all_missing$overload
+[1] "bar"
+
+$all_missing$x_missing
+[1] TRUE
+
+$all_missing$y_missing
+[1] TRUE
+
+
+
 ##com.oracle.truffle.r.test.functions.TestS3Dispatch.runRSourceTests#
 #{ source("tmptest/S3/nextMethod.R") }
 called foo.default with  42

com.oracle.truffle.r.test/src/com/oracle/truffle/r/test/functions/S3/R/missingAsNULL1.R

@@ -0,0 +1,24 @@
+# Copyright (c) 2020, 2020, Oracle and/or its affiliates. All rights reserved.
+# DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
+#
+# This code is free software; you can redistribute it and/or modify it
+# under the terms of the GNU General Public License version 3 only, as
+# published by the Free Software Foundation.
+#
+# This code is distributed in the hope that it will be useful, but WITHOUT
+# ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+# FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
+# version 3 for more details (a copy is included in the LICENSE file that
+# accompanied this code).
+#
+# You should have received a copy of the GNU General Public License version
+# 3 along with this work; if not, write to the Free Software Foundation,
+# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
+#
+# Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
+# or visit www.oracle.com if you need additional information or have any
+# questions.
+
+foo <- function(x, ..., abc = 'default_value') UseMethod('foo')
+foo.NULL <- function(x, ..., abc) list(overload = "NULL", x_missing = missing(x), args = list(...))
+print(list(foo(), foo(NULL)))

com.oracle.truffle.r.test/src/com/oracle/truffle/r/test/functions/S3/R/missingAsNULL2.R

@@ -0,0 +1,26 @@
+# Copyright (c) 2020, 2020, Oracle and/or its affiliates. All rights reserved.
+# DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
+#
+# This code is free software; you can redistribute it and/or modify it
+# under the terms of the GNU General Public License version 3 only, as
+# published by the Free Software Foundation.
+#
+# This code is distributed in the hope that it will be useful, but WITHOUT
+# ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+# FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
+# version 3 for more details (a copy is included in the LICENSE file that
+# accompanied this code).
+#
+# You should have received a copy of the GNU General Public License version
+# 3 along with this work; if not, write to the Free Software Foundation,
+# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
+#
+# Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
+# or visit www.oracle.com if you need additional information or have any
+# questions.
+
+foo <- function(x, y, z) UseMethod('foo')
+foo.NULL <- function(x, y, z) list(overload = "bar", x_missing = missing(x), y_missing = missing(y))
+foo.bar <- function(x, y, z) list(overload = "bar", x_missing = missing(x), y_missing = missing(y))
+indirect <- function(...) foo(...)
+print(list(first_missing = indirect(y=structure(33, class='bar')), all_missing = indirect()))