More internals do generic dispatch, fix NA handling in CastIntegerNode

Author: steve-s

com.oracle.truffle.r.nodes.builtin/src/com/oracle/truffle/r/nodes/builtin/base/IsFiniteFunctions.java

@@ -146,7 +146,7 @@ protected RLogicalVector doFunComplex(RAbstractComplexVector x, ComplexPredicate
         }
     }
 
-    @RBuiltin(name = "is.finite", kind = PRIMITIVE, parameterNames = {"x"}, behavior = PURE)
+    @RBuiltin(name = "is.finite", kind = PRIMITIVE, dispatch = INTERNAL_GENERIC, parameterNames = {"x"}, behavior = PURE)
     public abstract static class IsFinite extends Adapter {
 
         static {
@@ -184,7 +184,7 @@ protected RLogicalVector doIsFinite(RAbstractComplexVector vec) {
         }
     }
 
-    @RBuiltin(name = "is.infinite", kind = PRIMITIVE, parameterNames = {"x"}, behavior = PURE)
+    @RBuiltin(name = "is.infinite", kind = PRIMITIVE, dispatch = INTERNAL_GENERIC, parameterNames = {"x"}, behavior = PURE)
     public abstract static class IsInfinite extends Adapter {
 
         static {

com.oracle.truffle.r.nodes.builtin/src/com/oracle/truffle/r/nodes/builtin/base/IsTypeFunctions.java

@@ -136,6 +136,11 @@ protected byte isRecursive(@SuppressWarnings("unused") RExternalPtr obj) {
             return RRuntime.LOGICAL_FALSE;
         }
 
+        @Specialization
+        protected byte isRecursive(@SuppressWarnings("unused") RSymbol symbol) {
+            return RRuntime.LOGICAL_FALSE;
+        }
+
         @Fallback
         protected byte isRecursiveFallback(@SuppressWarnings("unused") Object value) {
             return RRuntime.LOGICAL_TRUE;

com.oracle.truffle.r.nodes/src/com/oracle/truffle/r/nodes/unary/CastIntegerNode.java

@@ -176,7 +176,7 @@ protected RAbstractIntVector doDoubleVector(RAbstractDoubleVector x,
         if (useClosure()) {
             return (RAbstractIntVector) castWithReuse(RType.Integer, operand, naProfile.getConditionProfile());
         }
-        return vectorCopy(operand, naCheck.convertDoubleVectorToIntData(operand), naCheck.neverSeenNA());
+        return vectorCopy(operand, naCheck.convertDoubleVectorToIntData(operand), naCheck.neverSeenNAOrNaN());
     }
 
     @Specialization

com.oracle.truffle.r.runtime/src/com/oracle/truffle/r/runtime/ops/na/NACheck.java

@@ -228,6 +228,10 @@ public boolean neverSeenNA() {
         return state != CHECK && !seenNaN;
     }
 
+    public boolean neverSeenNAOrNaN() {
+        return neverSeenNA() && seenNaN;
+    }
+
     public boolean hasNeverBeenTrue() {
         return neverSeenNA();
     }