Skip to content

Commit 5350f0a

Browse files
author
Pavel Marek
committed
Stop ignoring some unit tests
(cherry picked from commit fb99907)
1 parent 144415e commit 5350f0a

File tree

3 files changed

+4
-6
lines changed

3 files changed

+4
-6
lines changed

com.oracle.truffle.r.test/src/com/oracle/truffle/r/test/builtins/TestBuiltin_gsub.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -245,9 +245,8 @@ public void testGsubPCRE() {
245245
// Tests with UTF-8 strings
246246
assertEval("{ gsub(pattern = 'a*', replacement = 'x', x = 'ÄaÄ', perl = TRUE) }");
247247
assertEval("{ gsub(pattern = 'a*', replacement = 'x', x = 'ÄaaaaÄ', perl = TRUE) }");
248-
assertEval(Ignored.ImplementationError, "{ gsub(pattern = 'Ä*', replacement = 'x', x = 'aÄÄÄÄÄb', perl = TRUE) }");
248+
assertEval("{ gsub(pattern = 'Ä*', replacement = 'x', x = 'aÄÄÄÄÄb', perl = TRUE) }");
249249

250-
// FIXME: Enable once unicode support is implemented.
251-
assertEval(Ignored.ImplementationError, "{ gsub('([⚽])', '\\\\1', '─', perl=TRUE)} ");
250+
assertEval("{ gsub('([⚽])', '\\\\1', '─', perl=TRUE)} ");
252251
}
253252
}

com.oracle.truffle.r.test/src/com/oracle/truffle/r/test/builtins/TestBuiltin_strsplit.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -177,6 +177,6 @@ public void testStrSplit() {
177177
// This test is ignored because it is a special case with an empty match at the beginning
178178
// and positive and negative lookarounds. Empty match at the beginning is normally
179179
// replaced by an empty character vector, but in this case gnur does not do that.
180-
assertEval(Ignored.ImplementationError, "strsplit('/some/path/to/somewhere' , '^(?=/)(?!//)|(?<!^)(?<!^/)/', perl = TRUE)");
180+
assertEval("strsplit('/some/path/to/somewhere' , '^(?=/)(?!//)|(?<!^)(?<!^/)/', perl = TRUE)");
181181
}
182182
}

com.oracle.truffle.r.test/src/com/oracle/truffle/r/test/builtins/TestBuiltin_sub.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -167,9 +167,8 @@ public void testSub() {
167167
assertEval("{ sub(pattern = 'a*', replacement = 'x', x = 'ÄaÄ', perl = TRUE) }");
168168
assertEval("{ sub(pattern = 'a*', replacement = 'x', x = 'ÄaaaaÄ', perl = TRUE) }");
169169

170-
// FIXME
171170
// Expected output: [1] "xaÄÄÄÄÄb"
172171
// FastR output: [1] "axÄÄÄÄb"
173-
assertEval(Ignored.ImplementationError, "{ sub(pattern = 'Ä*', replacement = 'x', x = 'aÄÄÄÄÄb', perl = TRUE) }");
172+
assertEval("{ sub(pattern = 'Ä*', replacement = 'x', x = 'aÄÄÄÄÄb', perl = TRUE) }");
174173
}
175174
}

0 commit comments

Comments
 (0)