VectorDataLibrary.materializeCharSXPStorage throws UnsupportedMessageException by default

(cherry picked from commit 19ec7c6)

Author: Pavel Marek

com.oracle.truffle.r.ffi.impl/src/com/oracle/truffle/r/ffi/impl/nodes/AsCharNode.java

@@ -26,6 +26,7 @@
 import com.oracle.truffle.api.dsl.Fallback;
 import com.oracle.truffle.api.dsl.Specialization;
 import com.oracle.truffle.api.dsl.TypeSystemReference;
+import com.oracle.truffle.api.interop.UnsupportedMessageException;
 import com.oracle.truffle.api.library.CachedLibrary;
 import com.oracle.truffle.api.profiles.ConditionProfile;
 import com.oracle.truffle.r.nodes.unary.CastStringNode;
@@ -60,7 +61,12 @@ protected CharSXPWrapper asChar(RStringVector obj,
         if (zeroLengthProfile.profile(obj.getLength() == 0)) {
             return CharSXPWrapper_NA;
         } else {
-            Object newCharSXPData = dataLib.materializeCharSXPStorage(obj.getData());
+            Object newCharSXPData = null;
+            try {
+                newCharSXPData = dataLib.materializeCharSXPStorage(obj.getData());
+            } catch (UnsupportedMessageException e) {
+                throw RInternalError.shouldNotReachHere(e);
+            }
             obj.setData(newCharSXPData);
             CharSXPWrapper result = dataLib.getCharSXPAt(obj.getData(), 0);
             return naProfile.profile(RRuntime.isNA(result.getContents())) ? CharSXPWrapper_NA : result;

com.oracle.truffle.r.ffi.impl/src/com/oracle/truffle/r/ffi/impl/nodes/SetStringEltNode.java

@@ -24,7 +24,9 @@
 
 import com.oracle.truffle.api.dsl.GenerateUncached;
 import com.oracle.truffle.api.dsl.Specialization;
+import com.oracle.truffle.api.interop.UnsupportedMessageException;
 import com.oracle.truffle.api.library.CachedLibrary;
+import com.oracle.truffle.r.runtime.RInternalError;
 import com.oracle.truffle.r.runtime.data.CharSXPWrapper;
 import com.oracle.truffle.r.runtime.data.RStringVector;
 import com.oracle.truffle.r.runtime.data.VectorDataLibrary;
@@ -38,7 +40,12 @@ public static SetStringEltNode create() {
     @Specialization
     Object doIt(RStringVector vector, long index, CharSXPWrapper element,
                     @CachedLibrary(limit = "getTypedVectorDataLibraryCacheSize()") VectorDataLibrary dataLibrary) {
-        Object newCharSXPData = dataLibrary.materializeCharSXPStorage(vector.getData());
+        Object newCharSXPData = null;
+        try {
+            newCharSXPData = dataLibrary.materializeCharSXPStorage(vector.getData());
+        } catch (UnsupportedMessageException e) {
+            throw RInternalError.shouldNotReachHere(e);
+        }
         vector.setData(newCharSXPData);
         dataLibrary.setCharSXPAt(vector.getData(), (int) index, element);
         return null;

com.oracle.truffle.r.ffi.impl/src/com/oracle/truffle/r/ffi/impl/nodes/StringEltNode.java

@@ -25,8 +25,10 @@
 import com.oracle.truffle.api.CompilerDirectives;
 import com.oracle.truffle.api.dsl.GenerateUncached;
 import com.oracle.truffle.api.dsl.Specialization;
+import com.oracle.truffle.api.interop.UnsupportedMessageException;
 import com.oracle.truffle.api.library.CachedLibrary;
 import com.oracle.truffle.r.runtime.RError;
+import com.oracle.truffle.r.runtime.RInternalError;
 import com.oracle.truffle.r.runtime.data.RStringVector;
 import com.oracle.truffle.r.runtime.data.VectorDataLibrary;
 
@@ -40,7 +42,12 @@ public static StringEltNode create() {
     Object doStringVector(RStringVector stringVector, long index,
                     @CachedLibrary(limit = "getTypedVectorDataLibraryCacheSize()") VectorDataLibrary genericDataLib,
                     @CachedLibrary("stringVector.getData()") VectorDataLibrary stringVecDataLib) {
-        Object newCharSXPData = stringVecDataLib.materializeCharSXPStorage(stringVector.getData());
+        Object newCharSXPData = null;
+        try {
+            newCharSXPData = stringVecDataLib.materializeCharSXPStorage(stringVector.getData());
+        } catch (UnsupportedMessageException e) {
+            throw RInternalError.shouldNotReachHere(e);
+        }
         stringVector.setData(newCharSXPData);
         if (index > Integer.MAX_VALUE) {
             CompilerDirectives.transferToInterpreter();

com.oracle.truffle.r.runtime/src/com/oracle/truffle/r/runtime/data/RStringVector.java

@@ -426,7 +426,12 @@ public void wrapStrings() {
     public void wrapStrings(ConditionProfile isNativized, ConditionProfile isWrapped) {
         if (isNativized.profile(!isNativized())) {
             VectorDataLibrary dataLib = getUncachedDataLib();
-            Object newCharSXPData = dataLib.materializeCharSXPStorage(data);
+            Object newCharSXPData = null;
+            try {
+                newCharSXPData = dataLib.materializeCharSXPStorage(data);
+            } catch (UnsupportedMessageException e) {
+                throw RInternalError.shouldNotReachHere(e);
+            }
             if (isWrapped.profile(newCharSXPData == data)) {
                 return;
             }

com.oracle.truffle.r.runtime/src/com/oracle/truffle/r/runtime/data/VectorDataLibrary.java

@@ -151,13 +151,15 @@ public boolean isWriteable(Object data) {
      * {@link VectorDataLibrary}. Moreover, the receiver should transform into an object containing
      * {@link CharSXPWrapper} data, if possible.
      *
+     * Must be implemented when {@code getType() == Character}.
+     *
      * If the result is the same as the {@code data}, it means that the receiver already has
      * materialized CharSXP storage.
      * 
      * @see #materialize(Object)
      */
-    public Object materializeCharSXPStorage(Object data) {
-        return null;
+    public Object materializeCharSXPStorage(Object data) throws UnsupportedMessageException {
+        throw UnsupportedMessageException.create();
     }
 
     /**
@@ -1058,15 +1060,15 @@ public void setString(Object receiver, RandomAccessWriteIterator it, int index,
     }
 
     public void setCharSXPAt(Object receiver, int index, CharSXPWrapper value) {
-        throw notWriteableError(receiver, "setStringAt");
+        throw notWriteableError(receiver, "setCharSXPAt");
     }
 
     public void setNextCharSXP(Object receiver, SeqWriteIterator it, CharSXPWrapper value) {
-        throw notWriteableError(receiver, "setNextString");
+        throw notWriteableError(receiver, "setNextCharSXP");
     }
 
     public void setCharSXP(Object receiver, RandomAccessWriteIterator it, int index, CharSXPWrapper value) {
-        throw notWriteableError(receiver, "setString");
+        throw notWriteableError(receiver, "setCharSXP");
     }
 
     private final ConditionProfile emptyStringProfile = ConditionProfile.createBinaryProfile();
@@ -1699,9 +1701,11 @@ public Object materialize(Object data) {
         @Override
         public Object materializeCharSXPStorage(Object data) {
             verifyIfSlowAssertsEnabled(data);
-            Object result = delegate.materializeCharSXPStorage(data);
-            if (result == null) {
-                throw RInternalError.shouldNotReachHere("materializeCharSXPStorage message not implemented for " + delegate.toString());
+            Object result = null;
+            try {
+                result = delegate.materializeCharSXPStorage(data);
+            } catch (UnsupportedMessageException e) {
+                throw RInternalError.shouldNotReachHere(e);
             }
             assert result != null;
             return result;