Skip to content

Commit 38cd390

Browse files
authored
test(Popover): add better comment about disabled Axe rule (#5608)
1 parent ba60084 commit 38cd390

File tree

1 file changed

+5
-7
lines changed

1 file changed

+5
-7
lines changed

test/components/Popover.spec.ts

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -40,13 +40,11 @@ describe('Popover', () => {
4040

4141
expect(await axe(wrapper.element, {
4242
rules: {
43-
// "ARIA dialog and alertdialog nodes should have an accessible name (aria-dialog-name)"
44-
45-
// Fix any of the following:
46-
// aria-label attribute does not exist or is empty
47-
// aria-labelledby attribute does not exist, references elements that do not exist or references elements that are empty
48-
// Element has no title attribute
49-
'aria-dialog-name': { enabled: false }
43+
// RekaUI does not handle nor check for aria-dialog-name in their tests either
44+
// https://github.com/unovue/reka-ui/blob/v2/packages/core/src/Popover/Popover.test.ts
45+
'aria-dialog-name': {
46+
enabled: false
47+
}
5048
}
5149
})).toHaveNoViolations()
5250
})

0 commit comments

Comments
 (0)