Skip to content

feat: add suggested packages to comparison package selector #873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
thasmo wants to merge 1 commit into
base: main
Choose a base branch
from
+34 −0
Draft

feat: add suggested packages to comparison package selector #873

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 34 additions & 0 deletions app/components/Compare/PackageSelector.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,16 @@

const isSearching = computed(() => status.value === 'pending')

const suggestedPackagesCandidates = ['vue', 'svelte', 'solid-js', 'react']

const suggestedPackages = computed(() => {
return suggestedPackagesCandidates.includes(packages.value[0])

Check failure on line 23 in app/components/Compare/PackageSelector.vue

View workflow job for this annotation

GitHub Actions / test 

Argument of type 'string | undefined' is not assignable to parameter of type 'string'.
? suggestedPackagesCandidates
.filter(name => !packages.value.includes(name))
.slice(0, Math.max(0, 4 - packages.value.length))
: []
})

// Filter out already selected packages
const filteredResults = computed(() => {
if (!searchData.value?.objects) return []
Expand Down Expand Up @@ -78,6 +88,30 @@
<span class="i-carbon:close w-3.5 h-3.5" aria-hidden="true" />
</button>
</div>

<p class="flex-1"></p>

<!-- suggested packages -->
<div
v-for="pkg in suggestedPackages"
:key="pkg"
class="inline-flex items-center gap-2 px-3 py-1.5 border-border rounded-md"
>
<NuxtLink
:to="`/${pkg}`"
class="font-mono text-sm text-fg hover:text-accent transition-colors"
>
{{ pkg }}
</NuxtLink>
<button
type="button"
class="text-fg-subtle hover:text-fg transition-colors focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-accent/50 rounded"
:aria-label="$t('compare.selector.add_package', { package: pkg })"
@click="addPackage(pkg)"
>
<span class="i-carbon:add w-3.5 h-3.5" aria-hidden="true" />
</button>
</div>
</div>

<!-- Add package input -->
Expand Down
Loading