Merge pull request #794 from nipype/bugfix-task-eq

Bugfix-task-eq

Author: tclose

pydra/compose/base/task.py

@@ -404,6 +404,8 @@ def __iter__(self) -> ty.Generator[str, None, None]:
     def __eq__(self, other: ty.Any) -> bool:
         """Check if two tasks are equal"""
         values = attrs.asdict(self, recurse=False)
+        if not isinstance(other, Task):
+            return False
         try:
             other_values = attrs.asdict(other, recurse=False)
         except AttributeError:

pydra/compose/tests/test_python_equivalence.py

@@ -237,3 +237,13 @@ def Square(in_val):
     outputs = Square(in_val=2.0)()
     assert outputs.squared == 4.0
     assert outputs.cubed == 8.0
+
+
+def test_non_task_eq():
+    """Checks tasks can be compared to non-tasks"""
+
+    @python.define
+    def Square(in_val):
+        return in_val**2, in_val**3
+
+    assert Square(in_val=1) != 42