Don't require access to private windows

[jacktose]

Is this a feature request or a bug?

Bug

What is the current behavior?

Extension page (in Firefox 67+) says:

Requires Access to Private Windows
This extension has access to your online activities while private browsing.

What is the expected or desired behavior?

Price Tracker should not require access to private windows.

It should allow the user to choose whether it is allowed to run in private windows.
Or, if it's not intended to work in private windows (as #226 seems to suggest), it should not be able to be allowed in private windows, if that's possible.

Version information (for bug reports)

• Firefox version: 67.0
• Your OS and version: Windows 10 1809
• Price Tracker extension version: 22.0.0

[biancadanforth]

Thank you for filing this issue.

The behavior you mention here (effective in Firefox 67) has changed since Price Tracker was launched (circa Firefox 63). As mentioned in the support article if you click "Learn More" next to the Private Browsing messaging in about:addons:

In previous Firefox versions, any extensions you installed would run in private and non-private browsing windows by default.

Starting in Firefox version 67, you will be able to decide which extensions will run while you are in private browsing.

This issue helped me to uncover a bug upstream that does not show these controls by default for some Mozilla extensions in about:addons. Thankfully, there is a workaround that we can apply in Price Tracker: add the new incognito key to our extension’s manifest.

In the meantime, this table describes how the extension currently behaves in various privacy contexts, including private browsing.

Our privacy policy links to a complete list of the data we collect, none of which is collected in private windows.

I did notice that our METRICS.md Opt-Out section, was not updated with the changes in #186; we should do that as part of closing this issue as well.