Skip to content

feat(auth): include credentials for fetch request #20003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
toufali wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −0
Open

feat(auth): include credentials for fetch request #20003

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions packages/fxa-auth-client/lib/client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,13 +264,21 @@ export default class AuthClient {
}

extraHeaders.set('Content-Type', 'application/json');

// Only include credentials for specific endpoints that may trigger WAF challenges
const includeCredentials = [
'/account/create',
'/password/forgot/send_otp',
].some((endpoint) => path.includes(endpoint));

try {
const response = await fetchOrTimeout(
this.url(path),
{
method,
headers: extraHeaders,
body: cleanStringify(payload),
credentials: includeCredentials ? 'include' : 'same-origin',
},
this.timeout
);
Expand Down
1 change: 1 addition & 0 deletions packages/fxa-auth-server/lib/server.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,7 @@ async function create(log, error, config, routes, db, statsd, glean, customs) {
// If we're accepting CORS from any origin then use Hapi's "ignore" mode,
// which is more forgiving of missing Origin header.
origin: config.corsOrigin[0] === '*' ? 'ignore' : config.corsOrigin,
credentials: true,
},
security: {
hsts: {
Expand Down
Loading