-
Notifications
You must be signed in to change notification settings - Fork 3
Open
Labels
good first issuePerfect for people new to the code base.Perfect for people new to the code base.type/enhancementNew or improved feature.New or improved feature.
Description
If you pass a valid, but non-existent, UUID to the delete-session-stats command, it will wrongly claim that the non-existent session was deleted. The plugin should inform the command sender that no such session exists.
Two potential solutions:
- Throw NoSuchElementException/IllegalArgumentException from the StatsStore implementation(s) and catch the exception in the command.
- Modify the StatsStore interface to return a boolean; true for success, false for failure. This should be possible on the JDBI side of things by just checking for the number of affected rows after statement execution.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
good first issuePerfect for people new to the code base.Perfect for people new to the code base.type/enhancementNew or improved feature.New or improved feature.