Skip to content

False positives on non-existent sessions in /ma delete-session-stats #3

@garbagemule

Description

@garbagemule

If you pass a valid, but non-existent, UUID to the delete-session-stats command, it will wrongly claim that the non-existent session was deleted. The plugin should inform the command sender that no such session exists.

Two potential solutions:

  • Throw NoSuchElementException/IllegalArgumentException from the StatsStore implementation(s) and catch the exception in the command.
  • Modify the StatsStore interface to return a boolean; true for success, false for failure. This should be possible on the JDBI side of things by just checking for the number of affected rows after statement execution.

Metadata

Metadata

Assignees

No one assigned

    Labels

    good first issuePerfect for people new to the code base.type/enhancementNew or improved feature.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions