From 62b6bb0ea68905485a91686932fc7721d08020ec Mon Sep 17 00:00:00 2001 From: Spandan More Date: Fri, 7 Feb 2025 17:14:34 -0500 Subject: [PATCH 1/3] Trim file path from Kineto File name to avoid errors when running from another directory --- src/trace_link/trace_linker.py | 1 + 1 file changed, 1 insertion(+) diff --git a/src/trace_link/trace_linker.py b/src/trace_link/trace_linker.py index 1123e45d..8617248f 100644 --- a/src/trace_link/trace_linker.py +++ b/src/trace_link/trace_linker.py @@ -117,6 +117,7 @@ def load_sync_dependencies( sync_dependencies = {} absolute_kineto_file = os.path.abspath(kineto_file) trace_dir = os.path.dirname(absolute_kineto_file) + kineto_file = os.path.basename(kineto_file) trace_analysis = TraceAnalysis(trace_dir=trace_dir, trace_files={rank: kineto_file}) cp_graph, success = trace_analysis.critical_path_analysis( rank=rank, annotation=annotation, instance_id=instance_id From a4a0ea217eb32eb786b37ebc93266de30a7ebd85 Mon Sep 17 00:00:00 2001 From: Spandan More Date: Mon, 24 Feb 2025 16:49:44 -0500 Subject: [PATCH 2/3] Changed var name --- src/trace_link/trace_linker.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/trace_link/trace_linker.py b/src/trace_link/trace_linker.py index 8617248f..cb243503 100644 --- a/src/trace_link/trace_linker.py +++ b/src/trace_link/trace_linker.py @@ -117,8 +117,8 @@ def load_sync_dependencies( sync_dependencies = {} absolute_kineto_file = os.path.abspath(kineto_file) trace_dir = os.path.dirname(absolute_kineto_file) - kineto_file = os.path.basename(kineto_file) - trace_analysis = TraceAnalysis(trace_dir=trace_dir, trace_files={rank: kineto_file}) + kineto_file_base = os.path.basename(kineto_file) + trace_analysis = TraceAnalysis(trace_dir=trace_dir, trace_files={rank: kineto_file_base}) cp_graph, success = trace_analysis.critical_path_analysis( rank=rank, annotation=annotation, instance_id=instance_id ) From d3243d93a1493378df54c47aa7f05d2f20d9c784 Mon Sep 17 00:00:00 2001 From: Spandan More Date: Fri, 14 Mar 2025 15:54:48 -0400 Subject: [PATCH 3/3] Rebased commit with latest changes --- src/trace_link/trace_linker.py | 16 +++++++++++----- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/src/trace_link/trace_linker.py b/src/trace_link/trace_linker.py index cb243503..64de2a45 100644 --- a/src/trace_link/trace_linker.py +++ b/src/trace_link/trace_linker.py @@ -119,11 +119,17 @@ def load_sync_dependencies( trace_dir = os.path.dirname(absolute_kineto_file) kineto_file_base = os.path.basename(kineto_file) trace_analysis = TraceAnalysis(trace_dir=trace_dir, trace_files={rank: kineto_file_base}) - cp_graph, success = trace_analysis.critical_path_analysis( - rank=rank, annotation=annotation, instance_id=instance_id - ) - if not success: - logging.error("Failed to load Critical Path Graph") + try: + cp_graph, success = trace_analysis.critical_path_analysis( + rank=rank, annotation=annotation, instance_id=instance_id + ) + if not success: + logging.error("Critical path analysis completed but failed to load Critical Path Graph.") + return sync_dependencies + + except ValueError as e: + logging.error("Critical path analysis encountered an invalid graph structure: %s", e) + # Optionally, you could log more details or include rank-specific information if relevant return sync_dependencies raw_events = trace_analysis.t.get_raw_trace_for_one_rank(rank=rank)["traceEvents"]