fix(2212): make enum constant inlining consistent with Strada behavior

[a-tarasyuk]

Fixes #2212

[jakebailey]

Hm, weird, what's going on here?

[a-tarasyuk]

I think this is because this case uses the default reference resolver

typescript-go/internal/compiler/emitter.go

Lines 84 to 94 in 3fae7ba

	importElisionEnabled := !options.VerbatimModuleSyntax.IsTrue() && !ast.IsInJSFile(sourceFile.AsNode())
	var emitResolver printer.EmitResolver
	var referenceResolver binder.ReferenceResolver
	if importElisionEnabled || options.GetJSXTransformEnabled() || !options.GetIsolatedModules() { // full emit resolver is needed for import ellision and const enum inlining
	emitResolver = host.GetEmitResolver()
	emitResolver.MarkLinkedReferencesRecursively(sourceFile)
	referenceResolver = emitResolver
	} else {
	referenceResolver = binder.NewReferenceResolver(options, binder.ReferenceResolverHooks{})
	}

[jakebailey]

Ah, I had forgotten about the runtime changes we made to make it easier to emit these without using the checker.

How much of that actually has to go to fix the linked issue? Or is it just impossible to resolve?

[a-tarasyuk]

I think replicating the following from the checker (evaluateEntity) should resolve the issue. This fix may not cover 100% of the previous behavior, however it should address this particular case without needing the entire GetEnumMemberValue dependency

typescript-go/internal/transformers/tstransforms/runtimesyntax.go

Lines 1115 to 1139 in 3fae7ba

	func (tx *RuntimeSyntaxTransformer) evaluateEntity(node *ast.Node, location *ast.Node) evaluator.Result {
	var result evaluator.Result
	if ast.IsEnumDeclaration(location) {
	memberCache := tx.enumMemberCache[location]
	if memberCache != nil {
	switch {
	case ast.IsIdentifier(node):
	result = memberCache[node.Text()]
	case ast.IsPropertyAccessExpression(node):
	access := node.AsPropertyAccessExpression()
	expression := access.Expression
	if ast.IsIdentifier(expression) && tx.isReferenceToEnum(expression, location) {
	result = memberCache[access.Name().Text()]
	}
	case ast.IsElementAccessExpression(node):
	access := node.AsElementAccessExpression()
	expression := access.Expression
	if ast.IsIdentifier(expression) && tx.isReferenceToEnum(expression, location) && ast.IsStringLiteralLike(access.ArgumentExpression) {
	result = memberCache[access.ArgumentExpression.Text()]
	}
	}
	}
	}
	return result
	}