From 2aad2ceaf114de29e8a3351f7a841788dcb017c1 Mon Sep 17 00:00:00 2001 From: zdevito Date: Fri, 19 Dec 2025 13:01:16 -0800 Subject: [PATCH] no whole archive Added when we redid bulid but it isn't necessary -- doesn't build shared libraries of intermediate crates, and I don't think things use dynamic lookup of symbols within our rust crate. Lets see if CI passes. Differential Revision: [D89570908](https://our.internmc.facebook.com/intern/diff/D89570908/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D89570908/)! [ghstack-poisoned] --- build_utils/src/lib.rs | 3 --- monarch_cpp_static_libs/build.rs | 3 --- 2 files changed, 6 deletions(-) diff --git a/build_utils/src/lib.rs b/build_utils/src/lib.rs index d42b187b7..9013df880 100644 --- a/build_utils/src/lib.rs +++ b/build_utils/src/lib.rs @@ -385,11 +385,8 @@ impl CppStaticLibsConfig { println!("cargo::rustc-link-search=native={}", self.rdma_lib_dir); println!("cargo::rustc-link-search=native={}", self.rdma_util_dir); - // Use whole-archive for rdma-core static libraries - println!("cargo::rustc-link-arg=-Wl,--whole-archive"); println!("cargo::rustc-link-lib=static=mlx5"); println!("cargo::rustc-link-lib=static=ibverbs"); - println!("cargo::rustc-link-arg=-Wl,--no-whole-archive"); // rdma_util helper library println!("cargo::rustc-link-lib=static=rdma_util"); diff --git a/monarch_cpp_static_libs/build.rs b/monarch_cpp_static_libs/build.rs index fdce92f75..e0655eabe 100644 --- a/monarch_cpp_static_libs/build.rs +++ b/monarch_cpp_static_libs/build.rs @@ -254,11 +254,8 @@ fn emit_link_directives(rdma_build_dir: &Path) { ); println!("cargo:rustc-link-search=native={}", rdma_util_dir.display()); - // Static libraries - use whole-archive for rdma-core static libraries - println!("cargo:rustc-link-arg=-Wl,--whole-archive"); println!("cargo:rustc-link-lib=static=mlx5"); println!("cargo:rustc-link-lib=static=ibverbs"); - println!("cargo:rustc-link-arg=-Wl,--no-whole-archive"); // rdma_util helper library println!("cargo:rustc-link-lib=static=rdma_util");