Skip to content

Commit 06bd0fa

Browse files
: test_config: renenable codec max frame tests
Summary: adjust and re-enable codec max frame tests disabled by D89089836 Reviewed By: dulinriley Differential Revision: D89568148
1 parent 1bedc14 commit 06bd0fa

File tree

1 file changed

+8
-6
lines changed

1 file changed

+8
-6
lines changed

python/tests/test_config.py

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313

1414
from monarch._rust_bindings.monarch_hyperactor.channel import BindSpec, ChannelTransport
1515
from monarch._rust_bindings.monarch_hyperactor.supervision import SupervisionError
16-
from monarch.actor import Actor, endpoint, this_proc
16+
from monarch.actor import Actor, endpoint, this_host
1717
from monarch.config import configured, get_global_config
1818

1919

@@ -94,7 +94,6 @@ def test_get_set_multiple() -> None:
9494
# This test tries to allocate too much memory for the GitHub actions
9595
# environment.
9696
@pytest.mark.oss_skip
97-
@pytest.mark.skip(reason="local procs now bypass channels -- they dispatch directly")
9897
def test_codec_max_frame_length_exceeds_default() -> None:
9998
"""Test that sending 10 chunks of 1GiB fails with default 10 GiB
10099
limit."""
@@ -117,8 +116,10 @@ def process_chunks(self, chunks):
117116

118117
with override_fault_hook():
119118
# Try to send 10 chunks of 1GiB each with default 10 GiB limit
120-
# This should fail due to serialization overhead
121-
proc = this_proc()
119+
# This should fail due to serialization overhead.
120+
# Spawn in separate proc so messages are serialized via Unix
121+
# sockets
122+
proc = this_host().spawn_procs()
122123

123124
# Create 10 chunks, 1GiB each (total 10GiB)
124125
chunks = [bytes(oneGiB) for _ in range(10)]
@@ -132,7 +133,6 @@ def process_chunks(self, chunks):
132133
# This test tries to allocate too much memory for the GitHub actions
133134
# environment.
134135
@pytest.mark.oss_skip
135-
@pytest.mark.skip(reason="local procs now bypass channels -- they dispatch directly")
136136
def test_codec_max_frame_length_with_increased_limit() -> None:
137137
"""Test that we can successfully send 10 chunks of 1GiB each with
138138
100 GiB limit."""
@@ -156,7 +156,9 @@ def process_chunks(self, chunks):
156156

157157
# Set the frame limit to confidently handle 10GiB
158158
with configured(codec_max_frame_length=oneHundredGiB):
159-
proc = this_proc()
159+
# Spawn in separate proc so messages are serialized via Unix
160+
# sockets
161+
proc = this_host().spawn_procs()
160162

161163
# Create 10 chunks, 1GiB each (total 10GiB)
162164
chunks = [bytes(oneGiB) for _ in range(10)]

0 commit comments

Comments
 (0)