diff --git a/CHANGELOG.md b/CHANGELOG.md index 7ccf4540..60b0a7fa 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,3 +1,8 @@ +## [0.6.4] - October 30, 2024 + +* Add null safety to example app +* Remove v1 Flutter Android embedding references + ## [0.6.3] - September 21, 2021 * Android: added method getContactsByEmail (@fjbatresv) diff --git a/android/build.gradle b/android/build.gradle index 2feed78f..783d40a1 100644 --- a/android/build.gradle +++ b/android/build.gradle @@ -23,6 +23,7 @@ apply plugin: 'com.android.library' android { compileSdkVersion 30 + namespace "flutter.plugins.contactsservice.contactsservice" defaultConfig { minSdkVersion 16 diff --git a/android/src/main/AndroidManifest.xml b/android/src/main/AndroidManifest.xml index a0d08137..3dff9547 100644 --- a/android/src/main/AndroidManifest.xml +++ b/android/src/main/AndroidManifest.xml @@ -1,5 +1,4 @@ - + diff --git a/android/src/main/java/flutter/plugins/contactsservice/contactsservice/ContactsServicePlugin.java b/android/src/main/java/flutter/plugins/contactsservice/contactsservice/ContactsServicePlugin.java index 8c69de78..b8e195ec 100644 --- a/android/src/main/java/flutter/plugins/contactsservice/contactsservice/ContactsServicePlugin.java +++ b/android/src/main/java/flutter/plugins/contactsservice/contactsservice/ContactsServicePlugin.java @@ -41,7 +41,6 @@ import io.flutter.plugin.common.MethodChannel.MethodCallHandler; import io.flutter.plugin.common.MethodChannel.Result; import io.flutter.plugin.common.PluginRegistry; -import io.flutter.plugin.common.PluginRegistry.Registrar; import static android.app.Activity.RESULT_CANCELED; import static android.provider.ContactsContract.CommonDataKinds; @@ -66,16 +65,6 @@ public class ContactsServicePlugin implements MethodCallHandler, FlutterPlugin, private final ExecutorService executor = new ThreadPoolExecutor(0, 10, 60, TimeUnit.SECONDS, new ArrayBlockingQueue(1000)); - private void initDelegateWithRegister(Registrar registrar) { - this.delegate = new ContactServiceDelegateOld(registrar); - } - - public static void registerWith(Registrar registrar) { - ContactsServicePlugin instance = new ContactsServicePlugin(); - instance.initInstance(registrar.messenger(), registrar.context()); - instance.initDelegateWithRegister(registrar); - } - private void initInstance(BinaryMessenger messenger, Context context) { methodChannel = new MethodChannel(messenger, "github.com/clovisnicolas/flutter_contacts"); methodChannel.setMethodCallHandler(this); @@ -295,8 +284,9 @@ public boolean onActivityResult(int requestCode, int resultCode, Intent intent) } else { Log.e(LOG_TAG, "onActivityResult - cursor.moveToFirst() returns false"); finishWithResult(FORM_OPERATION_CANCELED); - }}else{return true;} + } cursor.close(); + }else{return true;} return true; } @@ -374,24 +364,6 @@ private void openDeviceContactPicker(Result result, boolean localizedLabels) { result.success(FORM_COULD_NOT_BE_OPEN); } } - - private class ContactServiceDelegateOld extends BaseContactsServiceDelegate { - private final PluginRegistry.Registrar registrar; - - ContactServiceDelegateOld(PluginRegistry.Registrar registrar) { - this.registrar = registrar; - registrar.addActivityResultListener(this); - } - - @Override - void startIntent(Intent intent, int request) { - if (registrar.activity() != null) { - registrar.activity().startActivityForResult(intent, request); - } else { - registrar.context().startActivity(intent); - } - } - } private class ContactServiceDelegate extends BaseContactsServiceDelegate { private final Context context; diff --git a/example/android/app/build.gradle b/example/android/app/build.gradle index f8e8aad1..d9024a3f 100644 --- a/example/android/app/build.gradle +++ b/example/android/app/build.gradle @@ -15,7 +15,8 @@ apply plugin: 'com.android.application' apply from: "$flutterRoot/packages/flutter_tools/gradle/flutter.gradle" android { - compileSdkVersion 30 + compileSdkVersion 34 + namespace "flutter.plugins.contactsservice.contactsserviceexample" lintOptions { disable 'InvalidPackage' @@ -24,7 +25,7 @@ android { defaultConfig { // TODO: Specify your own unique Application ID (https://developer.android.com/studio/build/application-id.html). applicationId "flutter.plugins.contactsservice.contactsserviceexample" - minSdkVersion 16 + minSdkVersion flutter.minSdkVersion targetSdkVersion 30 versionCode 1 versionName "1.0" @@ -47,4 +48,4 @@ flutter { dependencies { androidTestImplementation 'androidx.test:runner:1.1.0' androidTestImplementation 'androidx.test:rules:1.1.0' -} \ No newline at end of file +} diff --git a/example/android/app/src/main/AndroidManifest.xml b/example/android/app/src/main/AndroidManifest.xml index c736548a..31edda6e 100644 --- a/example/android/app/src/main/AndroidManifest.xml +++ b/example/android/app/src/main/AndroidManifest.xml @@ -1,5 +1,4 @@ - +