fix: broken checkbox propagation for sync data loders

Author: lukasbach

packages/core/src/features/checkboxes/feature.ts

@@ -61,6 +61,9 @@ const withLoadingState = async <T>(
         items.filter((id) => id !== itemId),
       );
     }
+  } else {
+    // immediately completed, await anyway to keep errors in the same execution flow
+    await prom;
   }
 };
 

packages/core/src/features/sync-data-loader/feature.ts

@@ -58,5 +58,6 @@ export const syncDataLoaderFeature: FeatureImplementation = {
 
   itemInstance: {
     isLoading: () => false,
+    hasLoadedData: () => true,
   },
 };

packages/core/src/features/sync-data-loader/types.ts

@@ -27,7 +27,10 @@ export type SyncDataLoaderFeatureDef<T> = {
     retrieveChildrenIds: (itemId: string, skipFetch?: boolean) => string[];
   };
   itemInstance: {
+    /** Returns false. Provided for consistency with async data loader */
     isLoading: () => boolean;
+    /** Returns true. Provided for consistency with async data loader */
+    hasLoadedData: () => boolean;
   };
   hotkeys: never;
 };