Skip to content

Commit e8d2864

Browse files
committed
Fix failing tests and add more Python versions to Travis
1 parent 58528ea commit e8d2864

File tree

2 files changed

+14
-11
lines changed

2 files changed

+14
-11
lines changed

.travis.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,11 +9,13 @@ python:
99
- '3.2'
1010
- '3.3'
1111
- '3.4'
12+
- '3.5'
13+
- '3.6'
1214
- pypy
1315
- pypy3
1416
install:
1517
- pip install .
16-
- if [[ $TRAVIS_PYTHON_VERSION == 2.7 ]] || [[ $TRAVIS_PYTHON_VERSION == 3.4 ]]; then pip install .[lua]; fi
18+
- if [[ "$TRAVIS_PYTHON_VERSION" =~ ^(2.7|3.4|3.5|3.6)$ ]]; then pip install .[lua]; fi
1719
script: python setup.py nosetests
1820
deploy:
1921
provider: pypi

mockredis/tests/test_script.py

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
LIST1, LIST2,
1616
SET1,
1717
VAL1, VAL2, VAL3, VAL4,
18+
bVAL1, bVAL2, bVAL3, bVAL4,
1819
LPOP_SCRIPT
1920
)
2021

@@ -110,7 +111,7 @@ def test_register_script_lpush(self):
110111
script(keys=[LIST1], args=[VAL1, VAL2])
111112

112113
# validate insertion
113-
eq_([VAL2, VAL1], self.redis.lrange(LIST1, 0, -1))
114+
eq_([bVAL2, bVAL1], self.redis.lrange(LIST1, 0, -1))
114115

115116
def test_register_script_lpop(self):
116117
self.redis.lpush(LIST1, VAL2, VAL1)
@@ -122,7 +123,7 @@ def test_register_script_lpop(self):
122123

123124
# validate lpop
124125
eq_(VAL1, list_item)
125-
eq_([VAL2], self.redis.lrange(LIST1, 0, -1))
126+
eq_([bVAL2], self.redis.lrange(LIST1, 0, -1))
126127

127128
def test_register_script_rpoplpush(self):
128129
self.redis.lpush(LIST1, VAL2, VAL1)
@@ -134,8 +135,8 @@ def test_register_script_rpoplpush(self):
134135
script(keys=[LIST1, LIST2])
135136

136137
# validate rpoplpush
137-
eq_([VAL1], self.redis.lrange(LIST1, 0, -1))
138-
eq_([VAL2, VAL3, VAL4], self.redis.lrange(LIST2, 0, -1))
138+
eq_([bVAL1], self.redis.lrange(LIST1, 0, -1))
139+
eq_([bVAL2, bVAL3, bVAL4], self.redis.lrange(LIST2, 0, -1))
139140

140141
def test_register_script_rpop_lpush(self):
141142
self.redis.lpush(LIST1, VAL2, VAL1)
@@ -150,8 +151,8 @@ def test_register_script_rpop_lpush(self):
150151
script(keys=[LIST1, LIST2])
151152

152153
# validate rpop and then lpush
153-
eq_([VAL1], self.redis.lrange(LIST1, 0, -1))
154-
eq_([VAL2, VAL3, VAL4], self.redis.lrange(LIST2, 0, -1))
154+
eq_([bVAL1], self.redis.lrange(LIST1, 0, -1))
155+
eq_([bVAL2, bVAL3, bVAL4], self.redis.lrange(LIST2, 0, -1))
155156

156157
def test_register_script_client(self):
157158
# lpush two values in LIST1 in first instance of redis
@@ -170,16 +171,16 @@ def test_register_script_client(self):
170171

171172
# validate lpop from LIST1 in redis2
172173
eq_(VAL3, list_item)
173-
eq_([VAL4], redis2.lrange(LIST1, 0, -1))
174-
eq_([VAL1, VAL2], self.redis.lrange(LIST1, 0, -1))
174+
eq_([bVAL4], redis2.lrange(LIST1, 0, -1))
175+
eq_([bVAL1, bVAL2], self.redis.lrange(LIST1, 0, -1))
175176

176177
def test_eval_lpush(self):
177178
# lpush two values
178179
script_content = "redis.call('LPUSH', KEYS[1], ARGV[1], ARGV[2])"
179180
self.redis.eval(script_content, 1, LIST1, VAL1, VAL2)
180181

181182
# validate insertion
182-
eq_([VAL2, VAL1], self.redis.lrange(LIST1, 0, -1))
183+
eq_([bVAL2, bVAL1], self.redis.lrange(LIST1, 0, -1))
183184

184185
def test_eval_lpop(self):
185186
self.redis.lpush(LIST1, VAL2, VAL1)
@@ -190,7 +191,7 @@ def test_eval_lpop(self):
190191

191192
# validate lpop
192193
eq_(VAL1, list_item)
193-
eq_([VAL2], self.redis.lrange(LIST1, 0, -1))
194+
eq_([bVAL2], self.redis.lrange(LIST1, 0, -1))
194195

195196
def test_eval_lrem(self):
196197
self.redis.delete(LIST1)

0 commit comments

Comments
 (0)