Skip to content

Commit 7a5e2c9

Browse files
committed
[LV] Add test with threshold=0 and metadata forcing vectorization.
Test case for the mis-compile mentioned in #166247 (comment) The issue is that we don't generate a runtime check even though it is required to vectorize.
1 parent dc92bd0 commit 7a5e2c9

File tree

1 file changed

+109
-0
lines changed

1 file changed

+109
-0
lines changed
Lines changed: 109 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,109 @@
1+
; NOTE: Assertions have been autogenerated by utils/update_test_checks.py UTC_ARGS: --version 6
2+
; RUN: opt -p loop-vectorize -vectorize-memory-check-threshold=0 -S %s | FileCheck --check-prefix=LIMIT0 %s
3+
; RUN: opt -p loop-vectorize -vectorize-memory-check-threshold=1 -S %s | FileCheck --check-prefix=LIMIT1 %s
4+
5+
; FIXME: Currently this miscompiles with -vectorize-memory-check-threshold=0;
6+
; no runtime check is generated even though one is needed and !noalias
7+
; annotations are added.
8+
define i16 @runtime_checks_needed(ptr %src, ptr %dst) {
9+
; LIMIT0-LABEL: define i16 @runtime_checks_needed(
10+
; LIMIT0-SAME: ptr [[SRC:%.*]], ptr [[DST:%.*]]) {
11+
; LIMIT0-NEXT: [[ENTRY:.*:]]
12+
; LIMIT0-NEXT: br label %[[VECTOR_PH:.*]]
13+
; LIMIT0: [[VECTOR_PH]]:
14+
; LIMIT0-NEXT: [[TMP0:%.*]] = load i16, ptr [[SRC]], align 1, !alias.scope [[META0:![0-9]+]]
15+
; LIMIT0-NEXT: [[BROADCAST_SPLATINSERT:%.*]] = insertelement <2 x i16> poison, i16 [[TMP0]], i64 0
16+
; LIMIT0-NEXT: [[BROADCAST_SPLAT:%.*]] = shufflevector <2 x i16> [[BROADCAST_SPLATINSERT]], <2 x i16> poison, <2 x i32> zeroinitializer
17+
; LIMIT0-NEXT: br label %[[VECTOR_BODY:.*]]
18+
; LIMIT0: [[VECTOR_BODY]]:
19+
; LIMIT0-NEXT: [[INDEX:%.*]] = phi i64 [ 0, %[[VECTOR_PH]] ], [ [[INDEX_NEXT:%.*]], %[[VECTOR_BODY]] ]
20+
; LIMIT0-NEXT: [[TMP1:%.*]] = getelementptr inbounds i16, ptr [[DST]], i64 [[INDEX]]
21+
; LIMIT0-NEXT: store <2 x i16> [[BROADCAST_SPLAT]], ptr [[TMP1]], align 1, !alias.scope [[META3:![0-9]+]], !noalias [[META0]]
22+
; LIMIT0-NEXT: [[INDEX_NEXT]] = add nuw i64 [[INDEX]], 2
23+
; LIMIT0-NEXT: [[TMP2:%.*]] = icmp eq i64 [[INDEX_NEXT]], 1000
24+
; LIMIT0-NEXT: br i1 [[TMP2]], label %[[MIDDLE_BLOCK:.*]], label %[[VECTOR_BODY]], !llvm.loop [[LOOP5:![0-9]+]]
25+
; LIMIT0: [[MIDDLE_BLOCK]]:
26+
; LIMIT0-NEXT: br label %[[EXIT:.*]]
27+
; LIMIT0: [[EXIT]]:
28+
; LIMIT0-NEXT: ret i16 [[TMP0]]
29+
;
30+
; LIMIT1-LABEL: define i16 @runtime_checks_needed(
31+
; LIMIT1-SAME: ptr [[SRC:%.*]], ptr [[DST:%.*]]) {
32+
; LIMIT1-NEXT: [[ENTRY:.*:]]
33+
; LIMIT1-NEXT: br label %[[VECTOR_MEMCHECK:.*]]
34+
; LIMIT1: [[VECTOR_MEMCHECK]]:
35+
; LIMIT1-NEXT: [[SCEVGEP:%.*]] = getelementptr i8, ptr [[DST]], i64 2000
36+
; LIMIT1-NEXT: [[SCEVGEP1:%.*]] = getelementptr i8, ptr [[SRC]], i64 2
37+
; LIMIT1-NEXT: [[BOUND0:%.*]] = icmp ult ptr [[DST]], [[SCEVGEP1]]
38+
; LIMIT1-NEXT: [[BOUND1:%.*]] = icmp ult ptr [[SRC]], [[SCEVGEP]]
39+
; LIMIT1-NEXT: [[FOUND_CONFLICT:%.*]] = and i1 [[BOUND0]], [[BOUND1]]
40+
; LIMIT1-NEXT: br i1 [[FOUND_CONFLICT]], label %[[SCALAR_PH:.*]], label %[[VECTOR_PH:.*]]
41+
; LIMIT1: [[VECTOR_PH]]:
42+
; LIMIT1-NEXT: [[TMP0:%.*]] = load i16, ptr [[SRC]], align 1, !alias.scope [[META0:![0-9]+]]
43+
; LIMIT1-NEXT: [[BROADCAST_SPLATINSERT:%.*]] = insertelement <2 x i16> poison, i16 [[TMP0]], i64 0
44+
; LIMIT1-NEXT: [[BROADCAST_SPLAT:%.*]] = shufflevector <2 x i16> [[BROADCAST_SPLATINSERT]], <2 x i16> poison, <2 x i32> zeroinitializer
45+
; LIMIT1-NEXT: br label %[[VECTOR_BODY:.*]]
46+
; LIMIT1: [[VECTOR_BODY]]:
47+
; LIMIT1-NEXT: [[INDEX:%.*]] = phi i64 [ 0, %[[VECTOR_PH]] ], [ [[INDEX_NEXT:%.*]], %[[VECTOR_BODY]] ]
48+
; LIMIT1-NEXT: [[TMP1:%.*]] = getelementptr inbounds i16, ptr [[DST]], i64 [[INDEX]]
49+
; LIMIT1-NEXT: store <2 x i16> [[BROADCAST_SPLAT]], ptr [[TMP1]], align 1, !alias.scope [[META3:![0-9]+]], !noalias [[META0]]
50+
; LIMIT1-NEXT: [[INDEX_NEXT]] = add nuw i64 [[INDEX]], 2
51+
; LIMIT1-NEXT: [[TMP2:%.*]] = icmp eq i64 [[INDEX_NEXT]], 1000
52+
; LIMIT1-NEXT: br i1 [[TMP2]], label %[[MIDDLE_BLOCK:.*]], label %[[VECTOR_BODY]], !llvm.loop [[LOOP5:![0-9]+]]
53+
; LIMIT1: [[MIDDLE_BLOCK]]:
54+
; LIMIT1-NEXT: br label %[[EXIT:.*]]
55+
; LIMIT1: [[SCALAR_PH]]:
56+
; LIMIT1-NEXT: br label %[[LOOP:.*]]
57+
; LIMIT1: [[LOOP]]:
58+
; LIMIT1-NEXT: [[IV:%.*]] = phi i64 [ 0, %[[SCALAR_PH]] ], [ [[IV_NEXT:%.*]], %[[LOOP]] ]
59+
; LIMIT1-NEXT: [[L:%.*]] = load i16, ptr [[SRC]], align 1
60+
; LIMIT1-NEXT: [[GEP_DST:%.*]] = getelementptr inbounds i16, ptr [[DST]], i64 [[IV]]
61+
; LIMIT1-NEXT: store i16 [[L]], ptr [[GEP_DST]], align 1
62+
; LIMIT1-NEXT: [[IV_NEXT]] = add nuw nsw i64 [[IV]], 1
63+
; LIMIT1-NEXT: [[EC:%.*]] = icmp eq i64 [[IV_NEXT]], 1000
64+
; LIMIT1-NEXT: br i1 [[EC]], label %[[EXIT]], label %[[LOOP]], !llvm.loop [[LOOP8:![0-9]+]]
65+
; LIMIT1: [[EXIT]]:
66+
; LIMIT1-NEXT: [[L_LCSSA:%.*]] = phi i16 [ [[L]], %[[LOOP]] ], [ [[TMP0]], %[[MIDDLE_BLOCK]] ]
67+
; LIMIT1-NEXT: ret i16 [[L_LCSSA]]
68+
;
69+
entry:
70+
br label %loop
71+
72+
loop:
73+
%iv = phi i64 [ 0, %entry ], [ %iv.next, %loop ]
74+
%l = load i16, ptr %src, align 1
75+
%gep.dst = getelementptr inbounds i16, ptr %dst, i64 %iv
76+
store i16 %l, ptr %gep.dst, align 1
77+
%iv.next = add nsw nuw i64 %iv, 1
78+
%ec = icmp eq i64 %iv.next, 1000
79+
br i1 %ec, label %exit, label %loop, !llvm.loop !0
80+
81+
exit:
82+
ret i16 %l
83+
}
84+
85+
!0 = distinct !{!0, !2, !3}
86+
!1 = !{!"llvm.loop.mustprogress"}
87+
!2 = !{!"llvm.loop.vectorize.width", i32 2}
88+
!3 = !{!"llvm.loop.vectorize.enable", i1 true}
89+
90+
;.
91+
; LIMIT0: [[META0]] = !{[[META1:![0-9]+]]}
92+
; LIMIT0: [[META1]] = distinct !{[[META1]], [[META2:![0-9]+]]}
93+
; LIMIT0: [[META2]] = distinct !{[[META2]], !"LVerDomain"}
94+
; LIMIT0: [[META3]] = !{[[META4:![0-9]+]]}
95+
; LIMIT0: [[META4]] = distinct !{[[META4]], [[META2]]}
96+
; LIMIT0: [[LOOP5]] = distinct !{[[LOOP5]], [[META6:![0-9]+]], [[META7:![0-9]+]]}
97+
; LIMIT0: [[META6]] = !{!"llvm.loop.isvectorized", i32 1}
98+
; LIMIT0: [[META7]] = !{!"llvm.loop.unroll.runtime.disable"}
99+
;.
100+
; LIMIT1: [[META0]] = !{[[META1:![0-9]+]]}
101+
; LIMIT1: [[META1]] = distinct !{[[META1]], [[META2:![0-9]+]]}
102+
; LIMIT1: [[META2]] = distinct !{[[META2]], !"LVerDomain"}
103+
; LIMIT1: [[META3]] = !{[[META4:![0-9]+]]}
104+
; LIMIT1: [[META4]] = distinct !{[[META4]], [[META2]]}
105+
; LIMIT1: [[LOOP5]] = distinct !{[[LOOP5]], [[META6:![0-9]+]], [[META7:![0-9]+]]}
106+
; LIMIT1: [[META6]] = !{!"llvm.loop.isvectorized", i32 1}
107+
; LIMIT1: [[META7]] = !{!"llvm.loop.unroll.runtime.disable"}
108+
; LIMIT1: [[LOOP8]] = distinct !{[[LOOP8]], [[META6]]}
109+
;.

0 commit comments

Comments
 (0)