Skip to content

Conversation

@eafton
Copy link
Contributor

@eafton eafton commented Dec 3, 2025

WIP implementation of a pure libdbus tray implementation, should close #13666, #11703 and Taiko2k/Tauon#1772.

Notes:
-Some of the menu interfaces are unimplemented for now.
-Tray creation, icon/tooltip setting works properly.
-Menu export and callbacks are working.
-DestroyTray does not clean up memory for menus and entries.
-Various TODOs in the code are present.
-Canonical's protocol is used for menu export, the GIO menu protocol is unsupported.
-Currently there is no support for the old XEmbed tray protocol, that will come once more "toolkit" functionality (see #14395) gets implemented. Functionality for having multiple tray drivers is already implemented.
-Tooltips are supported unlike the old Ayatana implementation.

image

@ssokolow @smcv @slouken

@eafton eafton marked this pull request as draft December 3, 2025 19:17
@sezero
Copy link
Contributor

sezero commented Dec 3, 2025

Whitespace and style changes are making it difficult to read the actual changes.

Tiny patch to make it build on alder systems:

diff --git a/src/core/linux/SDL_dbus.h b/src/core/linux/SDL_dbus.h
index 738fc06..27dcd41 100644
--- a/src/core/linux/SDL_dbus.h
+++ b/src/core/linux/SDL_dbus.h
@@ -38,6 +38,9 @@
 #ifndef DBUS_TYPE_UNIX_FD
 #define DBUS_TYPE_UNIX_FD ((int)'h')
 #endif
+#ifndef DBUS_ERROR_UNKNOWN_PROPERTY
+#define DBUS_ERROR_UNKNOWN_PROPERTY "org.freedesktop.DBus.Error.UnknownProperty"
+#endif
 
 typedef struct SDL_DBusContext
 {

@eafton
Copy link
Contributor Author

eafton commented Dec 3, 2025

+#ifndef DBUS_ERROR_UNKNOWN_PROPERTY
+#define DBUS_ERROR_UNKNOWN_PROPERTY "org.freedesktop.DBus.Error.UnknownProperty"
+#endif

Implemented.

@eafton
Copy link
Contributor Author

eafton commented Dec 4, 2025

Menu export works now, I just gotta wire it up.

image

@C0rn3j
Copy link

C0rn3j commented Dec 6, 2025

Will this implementation count with being able to use scroll events?

Currently we use it to set volume up/down based on scroll up/down over the tray (albeit the support for that in the current tray ecosystem seems spotty).

https://github.com/Taiko2k/Tauon/blob/e943bef475eb555b6bd5769e02ec7f11f80d2d54/src/tauon/t_modules/t_dbus.py#L269-L289

@ssokolow
Copy link

ssokolow commented Dec 6, 2025

If I'm understanding the SDL docs correctly, the SDL API having its guts rewritten currently only exposes the ability to define a context menu and set an icon and tooltip.

(Which matches what I'm seeing in the diff where a quick Ctrl+F shows no mention of the D-Bus SecondaryActivate or Scroll signals... SecondaryActivate being middle click under KDE.)

@eafton
Copy link
Contributor Author

eafton commented Dec 6, 2025

Will this implementation count with being able to use scroll events?

Currently we use it to set volume up/down based on scroll up/down over the tray (albeit the support for that in the current tray ecosystem seems spotty).

https://github.com/Taiko2k/Tauon/blob/e943bef475eb555b6bd5769e02ec7f11f80d2d54/src/tauon/t_modules/t_dbus.py#L269-L289

If the maintainers approve, we can add this.

@slouken

@slouken
Copy link
Collaborator

slouken commented Dec 6, 2025

Will this implementation count with being able to use scroll events?
Currently we use it to set volume up/down based on scroll up/down over the tray (albeit the support for that in the current tray ecosystem seems spotty).
https://github.com/Taiko2k/Tauon/blob/e943bef475eb555b6bd5769e02ec7f11f80d2d54/src/tauon/t_modules/t_dbus.py#L269-L289

If the maintainers approve, we can add this.

@slouken

Sure, we can add this. Go ahead and create a separate follow-on PR once this lands and include Windows support as well.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pure DBus tray item implementation?

6 participants