use a macro for assertions to get proper error output including location

Author: cmnrd

include/reactor-cpp/assert.hh

@@ -67,16 +67,14 @@ constexpr inline void validate([[maybe_unused]] bool condition, [[maybe_unused]]
   }
 }
 
-// Use plain assert on Windows and when assertions are enabled.
-// Otherwise, the locations of assertion errors are not properly reported.
-#if defined(_WIN32) && !defined(NDEBUG)
-#define reactor_assert(condition) assert(condition)
+// assert macro that avoids unused variable warnings
+#ifdef NDEBUG
+#define reactor_assert(x)                                                                                              \
+  do {                                                                                                                 \
+    (void)sizeof(x);                                                                                                   \
+  } while (0)
 #else
-constexpr inline void reactor_assert([[maybe_unused]] bool condition) {
-  if constexpr (runtime_assertion) { // NOLINT
-    assert(condition);               // NOLINT
-  }
-}
+#define reactor_assert(x) assert(x)
 #endif
 
 template <typename E> constexpr auto extract_value(E enum_value) -> typename std::underlying_type<E>::type {