Merge branch 'string-view' into network-interfaces

Author: cmnrd

include/reactor-cpp/assert.hh

@@ -38,10 +38,10 @@ using EnvPhase = Environment::Phase;
 
 class ValidationError : public std::runtime_error {
 private:
-  static auto build_message(const std::string& msg) noexcept -> std::string;
+  static auto build_message(std::string_view msg) noexcept -> std::string;
 
 public:
-  explicit ValidationError(const std::string& msg)
+  explicit ValidationError(const std::string_view msg)
       : std::runtime_error(build_message(msg)) {}
 };
 
@@ -56,7 +56,7 @@ inline void print_debug_backtrace() {
 }
 #endif
 
-constexpr inline void validate([[maybe_unused]] bool condition, [[maybe_unused]] const std::string& message) {
+constexpr inline void validate([[maybe_unused]] bool condition, [[maybe_unused]] const std::string_view message) {
   if constexpr (runtime_validation) { // NOLINT
     if (!condition) {
 #ifdef __linux__

include/reactor-cpp/scheduler.hh

@@ -65,11 +65,11 @@ private:
   std::atomic<std::ptrdiff_t> size_{0};
   Semaphore sem_{0};
   std::ptrdiff_t waiting_workers_{0};
-  const unsigned int num_workers_;
+  const std::ptrdiff_t num_workers_;
   log::NamedLogger& log_;
 
 public:
-  explicit ReadyQueue(log::NamedLogger& log, unsigned num_workers)
+  explicit ReadyQueue(log::NamedLogger& log, std::ptrdiff_t num_workers)
       : num_workers_(num_workers)
       , log_(log) {}
 

lib/assert.cc

@@ -10,7 +10,7 @@
 
 namespace reactor {
 
-auto ValidationError::build_message(const std::string& msg) noexcept -> std::string {
+auto ValidationError::build_message(const std::string_view msg) noexcept -> std::string {
   std::stringstream string_stream;
   string_stream << "Validation Error! \"" << msg << "\"";
   return string_stream.str();

lib/scheduler.cc

@@ -137,7 +137,7 @@ void ReadyQueue::fill_up(std::vector<Reaction*>& ready_reactions) {
   // one worker running running, new_size - running_workers indicates the
   // number of additional workers needed to process all reactions.
   waiting_workers_ += -old_size;
-  auto running_workers = num_workers_ - waiting_workers_;
+  std::ptrdiff_t running_workers{num_workers_ - waiting_workers_};
   auto workers_to_wakeup = std::min(waiting_workers_, new_size - running_workers);
 
   // wakeup other workers_

lib/time.cc

@@ -19,9 +19,9 @@
 
 namespace reactor {
 
-constexpr size_t TIME_TO_STR_BUFFER_SIZE{20};
-constexpr size_t NANOSECONDS_IN_ONE_SECOND{1'000'000'000UL};
-constexpr size_t NANOSECOND_DIGITS{9};
+constexpr std::size_t TIME_TO_STR_BUFFER_SIZE{20};
+constexpr std::size_t NANOSECONDS_IN_ONE_SECOND{1'000'000'000UL};
+constexpr std::size_t NANOSECOND_DIGITS{9};
 
 inline namespace operators {