Skip to content

Commit c1e52c7

Browse files
committed
[LDC] PGO: Avoid COMDAT members with private linkage for Windows
To prevent according IR verifier errors with IR-based PGO ('comdat global value has private linkage').
1 parent a8f3c7a commit c1e52c7

File tree

1 file changed

+7
-2
lines changed

1 file changed

+7
-2
lines changed

llvm/lib/ProfileData/InstrProf.cpp

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -361,8 +361,13 @@ GlobalVariable *createPGOFuncNameVar(Module &M,
361361
else if (Linkage == GlobalValue::AvailableExternallyLinkage)
362362
Linkage = GlobalValue::LinkOnceODRLinkage;
363363
else if (Linkage == GlobalValue::InternalLinkage ||
364-
Linkage == GlobalValue::ExternalLinkage)
365-
Linkage = GlobalValue::PrivateLinkage;
364+
Linkage == GlobalValue::ExternalLinkage) {
365+
// LDC: use internal instead of private linkage for COFF (still local, but
366+
// allows for COMDATs on Windows)
367+
Linkage = Triple(M.getTargetTriple()).isOSBinFormatCOFF()
368+
? GlobalValue::InternalLinkage
369+
: GlobalValue::PrivateLinkage;
370+
}
366371

367372
auto *Value =
368373
ConstantDataArray::getString(M.getContext(), PGOFuncName, false);

0 commit comments

Comments
 (0)