Skip to content

Commit c99d27c

Browse files
Fixed bug and simplified code for finding significant digits
1 parent 076e6cd commit c99d27c

File tree

2 files changed

+2
-8
lines changed

2 files changed

+2
-8
lines changed

app/evaluation.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -261,7 +261,7 @@ def evaluation_function(response, answer, params, include_test_data=False) -> di
261261

262262
reserved_expressions_success, reserved_expressions = parse_reserved_expressions(reserved_expressions_strings, parameters, evaluation_result)
263263
if reserved_expressions_success is False:
264-
return evaluation_result
264+
return evaluation_result.serialise(include_test_data)
265265
reserved_expressions_parsed = {**reserved_expressions["learner"], **reserved_expressions["task"]}
266266
parameters.update({"reserved_keywords": parameters["context"]["reserved_keywords"]+list(reserved_expressions_parsed.keys())})
267267

app/utility/expression_utilities.py

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -424,13 +424,7 @@ def compute_relative_tolerance_from_significant_decimals(string):
424424
separator_indices.append(len(string))
425425
index = min(separator_indices)
426426
significant_characters = string[0:index].replace(".", "")
427-
index = 0
428-
for c in significant_characters:
429-
if c in "-0":
430-
index += 1
431-
else:
432-
break
433-
significant_characters = significant_characters[index:]
427+
significant_characters = significant_characters.lstrip("-0")
434428
rtol = 5*10**(-len(significant_characters))
435429
return rtol
436430

0 commit comments

Comments
 (0)