Merge pull request #230 from lambda-feedback/fix/default_relative_tolerance

Changed the relative tolerance to be calculated to 2 significant figu…

Author: m-messer

app/evaluation_tests.py

@@ -79,6 +79,18 @@ def test_CHEM40002_1_5_instance_2024_25(self):
         result = evaluation_function(response, answer, params)
         assert result["is_correct"] is True
 
+    def test_physical_qualities_no_tolerance(self):
+        params = {
+            "atol": 0.0,
+            "rtol": 0.0,
+            "strict_syntax": False,
+            "physical_quantity": True,
+            "elementary_functions": True,
+        }
+        response = "0.6 Nm"
+        answer = "0.5 Nm"
+        result = evaluation_function(response, answer, params)
+        assert result["is_correct"] is False
 
 if __name__ == "__main__":
     pytest.main(['-xk not slow', '--tb=short', '--durations=10', os.path.abspath(__file__)])

app/utility/expression_utilities.py

@@ -1,6 +1,9 @@
 # Default parameters for expression handling
 # Any contexts that use this collection of utility functions
 # must define values for theses parameters
+
+DEFAULT_SIGNIFICANT_FIGURES = 2
+
 default_parameters = {
     "complexNumbers": False,
     "convention": "equal_precedence",
@@ -471,7 +474,7 @@ def compute_relative_tolerance_from_significant_decimals(string):
         index = min(separator_indices)
         significant_characters = string[0:index].replace(".", "")
         significant_characters = significant_characters.lstrip("-0")
-        rtol = 5*10**(-len(significant_characters))
+        rtol = 5*10**(-max(len(significant_characters), DEFAULT_SIGNIFICANT_FIGURES))
     return rtol