Added warning for triple factorial

Author: m-messer

app/evaluation.py

@@ -288,6 +288,10 @@ def evaluation_function(response, answer, params, include_test_data=False) -> di
         if "!" in response:
             evaluation_result.add_feedback(("NOTATION_WARNING_FACTORIAL", symbolic_comparison_internal_messages("NOTATION_WARNING_FACTORIAL")(dict())))
 
+    if "!!!" in response:
+        evaluation_result.add_feedback(
+            ("NOTATION_WARNING_TRIPLE_FACTORIAL", symbolic_comparison_internal_messages("NOTATION_WARNING_TRIPLE_FACTORIAL")(dict())))
+
     reserved_expressions_success, reserved_expressions = parse_reserved_expressions(reserved_expressions_strings, parameters, evaluation_result)
     if reserved_expressions_success is False:
         return evaluation_result.serialise(include_test_data)

app/feedback/symbolic.py

@@ -21,6 +21,7 @@
     "PARSE_ERROR": f"`{inputs.get('x','')}` could not be parsed as a valid mathematical expression. Ensure that correct codes for input symbols are used, correct notation is used, that the expression is unambiguous and that all parentheses are closed.",
     "NOTATION_WARNING_EXPONENT": "Note that `^` cannot be used to denote exponentiation, use `**` instead.",
     "NOTATION_WARNING_FACTORIAL": "Note that `!` cannot be used to denote factorial, use `factorial(...)` instead.",
+    "NOTATION_WARNING_TRIPLE_FACTORIAL": "Note that `!!!` is not supported.",
     "EXPRESSION_NOT_EQUALITY": "The response was an expression but was expected to be an equality.",
     "EQUALITY_NOT_EXPRESSION": "The response was an equality but was expected to be an expression.",
     "EQUALITIES_EQUIVALENT": None,

app/tests/symbolic_evaluation_tests.py

@@ -1899,6 +1899,14 @@ def test_double_exclamation_mark_for_factorial(self, response, answer, value):
         result = evaluation_function(response, answer, params)
         assert result["is_correct"] is value
 
+    def test_warning_for_triple_factorial(self):
+        answer = '2^4!'
+        response = '2^4!!!'
+        params = {'strict_syntax': False}
+        result = evaluation_function(response, answer, params, include_test_data=True)
+        assert result["is_correct"] is False
+        assert "NOTATION_WARNING_TRIPLE_FACTORIAL" in result["tags"]
+
     def test_alternatives_to_input_symbols_takes_priority_over_elementary_function_alternatives(self):
         answer = "Ef*exp(x)"
         params = {