Merge pull request #202 from lambda-feedback/tr170-basic-generic-syntactical-comparison

Clarified feedback messages for syntactical comparison

Author: KarlLundengaard

app/feedback/symbolic_comparison.py

@@ -70,7 +70,9 @@
 }[tag]
 feedback_generators["response=answer"] = lambda tag: lambda inputs: {
     "TRUE": None, #"The response is equal to the expected answer.",
+    "TRUE_DETAILED": "The response matches the expected expression", #"The response is equal to the expected answer.",
     "FALSE": None, #"The response is not equal to the expected answer.",
+    "FALSE_DETAILED": "The response does not match the expected expression", #"The response is not equal to the expected answer.",
     "UNKNOWN": None, #"Cannot determine if answer is equal to response.",
 }[tag]
 feedback_generators["response=answer_where"] = lambda tag: lambda inputs: {

app/symbolic_comparison_evaluation.py

@@ -269,6 +269,14 @@ def same_symbols(unused_input):
         else:
             return {label+"_SAME_SYMBOLS"+"_FALSE"}
 
+
+    if parameters_dict.get("detailed_feedback", False) is True:
+        math_eq_label_TRUE = "TRUE_DETAILED"
+        math_eq_label_FALSE = "FALSE_DETAILED"
+    else:
+        math_eq_label_TRUE = "TRUE"
+        math_eq_label_FALSE = "FALSE"
+
     # Check for mathematical equivalence
     graph.add_evaluation_node(
         label,
@@ -281,7 +289,7 @@ def same_symbols(unused_input):
         label+"_TRUE",
         summary=str(lhs)+"="+str(rhs),
         details=str(lhs)+" is equal to "+str(rhs)+".",
-        feedback_string_generator=symbolic_feedback_generators["response=answer"]("TRUE")
+        feedback_string_generator=symbolic_feedback_generators["response=answer"](math_eq_label_TRUE)
     )
 
     graph.attach(
@@ -313,7 +321,7 @@ def same_symbols(unused_input):
         label+"_FALSE",
         summary=str(lhs)+"=\\="+str(rhs),
         details=str(lhs)+" is not equal to"+str(rhs)+".",
-        feedback_string_generator=symbolic_feedback_generators["response=answer"]("FALSE")
+        feedback_string_generator=symbolic_feedback_generators["response=answer"](math_eq_label_FALSE)
     )
 
     if parameters_dict["syntactical_comparison"] is True:

app/symbolic_comparison_evaluation_tests.py

@@ -1234,9 +1234,9 @@ def test_disabled_evaluation_nodes(self, response, answer, criteria, value, disa
             ("2*e**(2*I)", "2*e^(2*I)", "answer=response", True, ["answer=response_TRUE", "answer=response_SAME_SYMBOLS_TRUE", "answer=response_SYNTACTICAL_EQUIVALENCE_FALSE", "answer=response_SAME_FORM_EXPONENTIAL"], {}),
             ("e**(2*I)", "1*e^(2*I)", "answer=response", True, ["answer=response_TRUE", "answer=response_SAME_SYMBOLS_TRUE", "answer=response_SYNTACTICAL_EQUIVALENCE_FALSE", "answer=response_SAME_FORM_EXPONENTIAL"], {}),
             ("0.48+0.88*I", "1*e^(0.5*I)", "answer=response", False, ["answer=response_FALSE", "answer=response_SAME_FORM_UNKNOWN"], {}),
-            ("(x-4)^2-5", "(x-4)^2-5", "answer=response", True, ["answer=response_TRUE", "answer=response_SAME_SYMBOLS_TRUE", "answer=response_WRITTEN_AS_ANSWER_TRUE"], {}),
-            ("x^2-8x+11", "(x-4)^2-5", "answer=response", False, ["answer=response_TRUE", "answer=response_SAME_SYMBOLS_TRUE", "answer=response_WRITTEN_AS_ANSWER_FALSE"], {}),
-            ("(x-3)^2-3", "(x-4)^2-5", "answer=response", False, ["answer=response_FALSE", "answer=response_WRITTEN_AS_ANSWER_TRUE"], {}),
+            ("(x-4)^2-5", "(x-4)^2-5", "answer=response", True, ["answer=response_TRUE", "answer=response_SAME_SYMBOLS_TRUE", "answer=response_WRITTEN_AS_ANSWER_TRUE"], {"detailed_feedback": True}),
+            ("x^2-8x+11", "(x-4)^2-5", "answer=response", False, ["answer=response_TRUE", "answer=response_SAME_SYMBOLS_TRUE", "answer=response_WRITTEN_AS_ANSWER_FALSE"], {"detailed_feedback": True}),
+            ("(x-3)^2-3", "(x-4)^2-5", "answer=response", False, ["answer=response_FALSE", "answer=response_WRITTEN_AS_ANSWER_TRUE"], {"detailed_feedback": True}),
         ]
     )
     def test_syntactical_comparison(self, response, answer, criteria, value, feedback_tags, additional_params):