Fix serialize errors

Author: qdegraaf

src/commercetools/testing/cart_discounts.py

@@ -1,3 +1,4 @@
+import copy
 import datetime
 import typing
 import uuid
@@ -64,6 +65,22 @@ def urls(self):
             ("^(?P<id>[^/]+)$", "DELETE", self.delete_by_id),
         ]
 
+    def set_valid_from(
+            self, obj, action: models.CartDiscountSetValidFromAction
+    ):
+        # real API always increments version, so always apply new value.
+        new = copy.deepcopy(obj)
+        new["valid_from"] = action.valid_from.isoformat()
+        return new
+
+    def set_valid_until(
+            self, obj, action: models.CartDiscountSetValidUntilAction
+    ):
+        # real API always increments version, so always apply new value.
+        new = copy.deepcopy(obj)
+        new["valid_until"] = action.valid_until.isoformat()
+        return new
+
     _actions = {
         "setKey": update_attribute("key", "key"),
         "changeSortOrder": update_attribute("sortOrder", "sort_order"),
@@ -72,6 +89,6 @@ def urls(self):
         "setName": update_attribute("name", "name"),
         "setDescription": update_attribute("description", "description"),
         "setCartPredicate": update_attribute("cartPredicate", "cart_predicate"),
-        "setValidFrom": update_attribute("valid_from", "valid_from"),
-        "setValidUntil": update_attribute("valid_until", "valid_until")
+        "setValidFrom": set_valid_from,
+        "setValidUntil": set_valid_until
     }

src/commercetools/testing/discount_codes.py

@@ -1,3 +1,4 @@
+import copy
 import datetime
 import typing
 import uuid
@@ -58,6 +59,30 @@ def urls(self):
             ("^(?P<id>[^/]+)$", "POST", self.update_by_id),
         ]
 
+    def set_valid_from(
+            self, obj, action: models.DiscountCodeSetValidFromAction
+    ):
+        # real API always increments version, so always apply new value.
+        new = copy.deepcopy(obj)
+        new["valid_from"] = action.valid_from.isoformat()
+        return new
+
+    def set_valid_until(
+            self, obj, action: models.DiscountCodeSetValidUntilAction
+    ):
+        # real API always increments version, so always apply new value.
+        new = copy.deepcopy(obj)
+        new["valid_until"] = action.valid_until.isoformat()
+        return new
+
+    def change_cart_discounts(
+            self, obj, action: models.DiscountCodeChangeCartDiscountsAction
+    ):
+        # real API always increments version, so always apply new value.
+        new = copy.deepcopy(obj)
+        new["cart_discounts"] = [cart_discount.serialize() for cart_discount in action.cart_discounts]
+        return new
+
     _actions = {
         "changeIsActive": update_attribute("isActive", "is_active"),
         "setName": update_attribute("name", "name"),
@@ -67,6 +92,7 @@ def urls(self):
         "setMaxApplicationsPerCustomer": update_attribute(
             "maxApplicationsPerCustomer", "max_applications_per_customer"
         ),
-        "setValidFrom": update_attribute("valid_from", "valid_from"),
-        "setValidUntil": update_attribute("valid_until", "valid_until")
+        "setValidFrom": set_valid_from,
+        "setValidUntil": set_valid_until,
+        "changeCartDiscounts": change_cart_discounts
     }

src/commercetools/testing/extensions.py

@@ -1,3 +1,4 @@
+import copy
 import datetime
 import typing
 import uuid
@@ -51,6 +52,14 @@ def urls(self):
             ("^key=(?P<key>[^/]+)$", "DELETE", self.delete_by_key),
         ]
 
+    def change_triggers(
+            self, obj, action: models.ExtensionChangeTriggersAction
+    ):
+        # real API always increments version, so always apply new value.
+        new = copy.deepcopy(obj)
+        new["triggers"] = [trigger.serialize() for trigger in action.triggers]
+        return new
+
     _actions = {
-        "changeTriggers": update_attribute("triggers", "triggers"),
+        "changeTriggers": change_triggers,
     }

tests/platform/test_service_cart_discounts.py

@@ -114,7 +114,7 @@ def test_cart_discount_set_valid_from(old_client):
         actions=[models.CartDiscountSetValidFromAction(valid_from=datetime.now())],
     )
 
-    assert cart_discount.valid_from == datetime.now()
+    assert cart_discount.valid_from == datetime.now().isoformat()
 
 
 @pytest.mark.freeze_time("2021-03-01 12:34:56")
@@ -137,4 +137,4 @@ def test_cart_discount_set_valid_until(old_client):
         actions=[models.CartDiscountSetValidUntilAction(valid_until=datetime.now())],
     )
 
-    assert cart_discount.valid_until == datetime.now()
+    assert cart_discount.valid_until == datetime.now().isoformat()

tests/platform/test_service_discount_codes.py

@@ -73,7 +73,7 @@ def test_discount_code_update(old_client):
     assert discount_code.is_active is False
 
 
-@pytest.mark.freeze_time("2021-03-01 12:34:56")
+@pytest.mark.freeze_time("2021-03-01")
 def test_discount_code_set_valid_from(old_client):
     discount_code = old_client.discount_codes.create(
         models.DiscountCodeDraft(
@@ -95,7 +95,7 @@ def test_discount_code_set_valid_from(old_client):
     assert discount_code.valid_from == datetime.now()
 
 
-@pytest.mark.freeze_time("2021-03-01 12:34:56")
+@pytest.mark.freeze_time("2021-03-01")
 def test_discount_code_set_valid_until(old_client):
     discount_code = old_client.discount_codes.create(
         models.DiscountCodeDraft(
@@ -114,4 +114,40 @@ def test_discount_code_set_valid_until(old_client):
         actions=[models.DiscountCodeSetValidUntilAction(valid_until=datetime.now())],
     )
 
-    assert discount_code.valid_until == datetime.now()
+    assert discount_code.version == 2
+    assert discount_code.valid_until == datetime.now().isoformat()
+
+
+def test_discount_code_change_cart_discounts(old_client):
+    discount_code = old_client.discount_codes.create(
+        models.DiscountCodeDraft(
+            name=models.LocalizedString(en="en-discount_code"),
+            code="1337",
+            is_active=True,
+            cart_discounts=[],
+        )
+    )
+    assert discount_code.id
+    assert discount_code.cart_discounts == []
+
+    cart_discount = old_client.cart_discounts.create(
+        models.CartDiscountDraft(
+            name=models.LocalizedString(en="cart-discount-test"),
+            value=models.CartDiscountValueDraft(type="absolute"),
+            cart_predicate="sku",
+            sort_order="1",
+            requires_discount_code=True,
+        )
+    )
+    assert cart_discount.id
+
+    discount_code = old_client.discount_codes.update_by_id(
+        id=discount_code.id,
+        version=discount_code.version,
+        actions=[models.DiscountCodeChangeCartDiscountsAction(
+            cart_discounts=[models.CartDiscountResourceIdentifier(id=cart_discount.id)]
+        )],
+    )
+
+    assert discount_code.version == 2
+    assert discount_code.cart_discounts == cart_discount