Skip to content

Commit 176cac7

Browse files
committed
Fix incorrect customer test implementation
1 parent d011904 commit 176cac7

File tree

2 files changed

+28
-12
lines changed

2 files changed

+28
-12
lines changed

src/commercetools/testing/customers.py

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44

55
from commercetools import schemas, types
66
from commercetools.testing import abstract, utils
7+
from commercetools.testing.utils import create_commercetools_response
78

89

910
class CustomerModel(abstract.BaseModel):
@@ -80,3 +81,13 @@ def urls(self):
8081
("^(?P<id>[^/]+)$", "POST", self.update_by_id),
8182
("^(?P<id>[^/]+)$", "DELETE", self.delete_by_id),
8283
]
84+
85+
def create(self, request):
86+
obj = self._schema_draft().loads(request.body)
87+
data = self.model.add(obj)
88+
89+
# Convert to CustomerSignInResult
90+
data = {"customer": data, "cart": None}
91+
92+
expanded_data = self._expand(request, data)
93+
return create_commercetools_response(request, json=expanded_data)

tests/test_service_customers.py

Lines changed: 17 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -15,18 +15,19 @@ def _get_draft_object(**kwargs):
1515

1616

1717
def test_get_by_id(client):
18-
customer = client.customers.create(draft=_get_draft_object())
19-
assert customer.id
18+
result = client.customers.create(draft=_get_draft_object())
19+
assert result.customer.id
2020

21-
customer = client.customers.get_by_id(customer.id)
21+
customer = client.customers.get_by_id(result.customer.id)
2222
assert customer
2323

2424

2525
def test_get_by_key(client):
26-
customer = client.customers.create(draft=_get_draft_object(key="test-customer"))
27-
assert customer.key
26+
result = client.customers.create(draft=_get_draft_object(key="test-customer"))
27+
assert result.customer.key
28+
assert result.cart is None
2829

29-
customer = client.customers.get_by_key(customer.key)
30+
customer = client.customers.get_by_key(result.customer.key)
3031
assert customer
3132

3233

@@ -44,12 +45,16 @@ def test_query(client):
4445

4546

4647
def test_delete_by_id(client):
47-
customer = client.customers.create(draft=_get_draft_object())
48-
assert customer.id
49-
assert client.customers.delete_by_id(customer.id, version=customer.version)
48+
result = client.customers.create(draft=_get_draft_object())
49+
assert result.customer.id
50+
assert client.customers.delete_by_id(
51+
result.customer.id, version=result.customer.version
52+
)
5053

5154

5255
def test_delete_by_key(client):
53-
customer = client.customers.create(draft=_get_draft_object(key="test-customer"))
54-
assert customer.key
55-
assert client.customers.delete_by_key(customer.key, version=customer.version)
56+
result = client.customers.create(draft=_get_draft_object(key="test-customer"))
57+
assert result.customer.key
58+
assert client.customers.delete_by_key(
59+
result.customer.key, version=result.customer.version
60+
)

0 commit comments

Comments
 (0)