feat: enable HA hub agents by optionally depending on cert manager #366
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
weng271190436
force-pushed
the
weiweng/enable-ha-hub-agents
branch
from
766ac60 to
91a764b
Compare
weng271190436
commented
Dec 5, 2025
| // Add webhook readiness check AFTER controllers are set up (when ResourceInformer is initialized) | ||
| // This prevents webhook from accepting requests before discovery cache is populated | ||
| if opts.EnableWebhook { | ||
| if err := mgr.AddReadyzCheck("webhook-cache", webhook.ResourceInformerReadinessChecker(validator.ResourceInformer)); err != nil { |
Collaborator
Author
There was a problem hiding this comment.
This PR stacks on top of an informer readiness check change because now that I have multiple replicas of webhook servers, it becomes likely that some webhook servers might start serving requests before the cache is synced
weng271190436
force-pushed
the
weiweng/enable-ha-hub-agents
branch
3 times, most recently
from
7850aa5 to
177d5a7
Compare
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
added 5 commits
December 8, 2025 15:27
Signed-off-by: Wei Weng <Wei.Weng@microsoft.com>
Signed-off-by: Wei Weng <Wei.Weng@microsoft.com>
Signed-off-by: Wei Weng <Wei.Weng@microsoft.com>
Signed-off-by: Wei Weng <Wei.Weng@microsoft.com>
Signed-off-by: Wei Weng <Wei.Weng@microsoft.com>
weng271190436
force-pushed
the
weiweng/enable-ha-hub-agents
branch
from
177d5a7 to
69ab42b
Compare
ryanzhang-oss
approved these changes
Dec 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Currently the in memory 10-year self-signed cert cannot be shared among replicas of hub agents so only the leader has a valid cert registered with API server
Using cert manger decouples cert management and hub agent core functionality. It also does cert rotation.
Trying to partially address Azure/fleet#1224
Fixes #
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Special notes for your reviewer