fix: adjust dispute template validation, pass arbitrableaddress as context to data mappings

Author: kemuru

kleros-sdk/src/dataMappings/executeActions.ts

@@ -31,7 +31,7 @@ export const executeAction = async (mapping: ActionMapping, context = {}) => {
       return await fetchIpfsJsonAction(validateFetchIpfsJsonMapping(mapping));
     case "reality":
       mapping = validateRealityMapping(mapping);
-      return await retrieveRealityData(mapping.realityQuestionID, context.arbitrable);
+      return await retrieveRealityData(mapping.realityQuestionID, context.arbitrableAddress);
     default:
       throw new Error(`Unsupported action type: ${mapping.type}`);
   }

kleros-sdk/src/dataMappings/utils/disputeDetailsSchema.ts

@@ -55,13 +55,11 @@ const DisputeDetailsSchema = z.object({
   answers: z.array(AnswerSchema),
   policyURI: z.string(),
   attachment: AttachmentSchema.optional(),
-  frontendUrl: z.string(),
+  frontendUrl: z.string().optional(),
   metadata: MetadataSchema.optional(),
-  arbitrableChainID: z.string(),
-  arbitrableAddress: z.string(), // should be changed for ethAddressSchema eventually
   arbitratorChainID: z.string(),
-  arbitratorAddress: z.string(), // should be changed for ethAddressSchema eventually
-  category: z.string(),
+  arbitratorAddress: z.string(), // should be changed for ethAddressSchema eventually, but some
+  category: z.string().optional(),
   lang: z.string().optional(),
   specification: z.string().optional(),
   aliases: AliasSchema.optional(),

web/src/hooks/queries/usePopulatedDisputeData.ts

@@ -47,6 +47,7 @@ export const usePopulatedDisputeData = (disputeID?: string, arbitrableAddress?:
       if (isEnabled && !isError) {
         try {
           const { isCrossChainDispute, crossChainTemplateId } = crossChainData;
+          console.log({ crossChainData }); //crosschaindata's chainId is 0 here 🤔
 
           const templateId = isCrossChainDispute
             ? crossChainTemplateId
@@ -64,7 +65,8 @@ export const usePopulatedDisputeData = (disputeID?: string, arbitrableAddress?:
 
           const initialContext = {
             disputeID: disputeID,
-            arbitrable: arbitrableAddress,
+            arbitrableAddress: arbitrableAddress,
+            arbitrableChainID: "whereDoWeGetThisValueFrom?",
             graphApiKey: import.meta.env.REACT_APP_GRAPH_API_KEY,
             externalDisputeID: externalDisputeID,
           };

web/src/pages/DisputeTemplateView/index.tsx

@@ -166,8 +166,8 @@ const DisputeTemplateView = () => {
 
         setTimeout(() => {
           const initialContext = {
-            arbitrator: debouncedParams._arbitrator,
-            arbitrable: debouncedParams._arbitrable,
+            arbitratorAddress: debouncedParams._arbitrator,
+            arbitrableAddress: debouncedParams._arbitrable,
             arbitrableDisputeID: debouncedParams._arbitrableDisputeID,
             externalDisputeID: debouncedParams._externalDisputeID,
             templateID: debouncedParams._templateId,