Skip to content

Commit 3bc7d00

Browse files
kemurujaybuidl
authored andcommitted
fix(web): few fixable code smells
1 parent fb3a6a7 commit 3bc7d00

File tree

3 files changed

+5
-4
lines changed

3 files changed

+5
-4
lines changed

web/src/pages/Courts/TopSearch.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,13 @@ import React, { useMemo } from "react";
22
import { useNavigate } from "react-router-dom";
33
import { DropdownCascader } from "@kleros/ui-components-library";
44
import { StyledSkeleton } from "components/StyledSkeleton";
5+
import { isUndefined } from "utils/index";
56
import { useCourtTree, CourtTreeQuery } from "queries/useCourtTree";
67

78
const TopSearch: React.FC = () => {
89
const { data } = useCourtTree();
910
const navigate = useNavigate();
10-
const items = useMemo(() => typeof data !== "undefined" && [rootToItems(data.court)], [data]);
11+
const items = useMemo(() => !isUndefined(data) && [rootToItems(data.court)], [data]);
1112
return items ? (
1213
<DropdownCascader items={items} onSelect={(path: string) => navigate(path)} placeholder="Select Court" />
1314
) : (

web/src/pages/Dashboard/JurorInfo/TokenRewards.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,10 +24,10 @@ const TokenRewards: React.FC<ITokenRewards> = ({ token, amount, value }) => {
2424
return (
2525
<RewardContainer>
2626
{token && <GradientTokenIcons icon={token} />}
27-
<StyledH1>{amount ? amount : <StyledSkeleton width={76} />}</StyledH1>
27+
<StyledH1>{amount || <StyledSkeleton width={76} />}</StyledH1>
2828
<StyledH1>{token}</StyledH1>
2929
<label>$ </label>
30-
<label>{value ? value : <StyledSkeleton width={32} />}</label>
30+
<label>{value || <StyledSkeleton width={32} />}</label>
3131
</RewardContainer>
3232
);
3333
};

web/src/pages/Home/LatestCases.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ const LatestCases: React.FC = () => {
2121
<h1>Latest Cases</h1>
2222
<div className="disputes-container">
2323
{data
24-
? data.disputes.map((dispute, i) => <DisputeCard key={i} {...dispute} />)
24+
? data.disputes.map((dispute) => <DisputeCard key={dispute.id} {...dispute} />)
2525
: Array.from({ length: 3 }).map((_, index) => <StyledSkeleton key={index} width={312} height={260} />)}
2626
</div>
2727
</Container>

0 commit comments

Comments
 (0)