Skip to content

Commit 46f40e7

Browse files
authored
handle KeyError when get session (#6245)
1 parent 601ac0e commit 46f40e7

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

notebook/services/sessions/sessionmanager.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -189,7 +189,10 @@ def get_session(self, **kwargs):
189189

190190
raise web.HTTPError(404, u'Session not found: %s' % (', '.join(q)))
191191

192-
model = yield maybe_future(self.row_to_model(row))
192+
try:
193+
model = yield maybe_future(self.row_to_model(row))
194+
except KeyError as e:
195+
raise web.HTTPError(404, u'Session not found: %s' % str(e))
193196
raise gen.Return(model)
194197

195198
@gen.coroutine

notebook/services/sessions/tests/test_sessionmanager.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ def test_get_session_dead_kernel(self):
9494
session = self.create_session(path='/path/to/1/test1.ipynb', kernel_name='python')
9595
# kill the kernel
9696
sm.kernel_manager.shutdown_kernel(session['kernel']['id'])
97-
with self.assertRaises(KeyError):
97+
with self.assertRaises(web.HTTPError):
9898
self.loop.run_sync(lambda: sm.get_session(session_id=session['id']))
9999
# no sessions left
100100
listed = self.loop.run_sync(lambda: sm.list_sessions())

0 commit comments

Comments
 (0)