Skip to content

Commit 4da6a24

Browse files
committed
TODOs
1 parent 89356b9 commit 4da6a24

File tree

8 files changed

+9
-4
lines changed

8 files changed

+9
-4
lines changed

core/analysis_config.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
class AnalysisConfig:
22
file_path: str = None
3+
# TODO: turn this into a class. dict adds unnecessary complexity
34
options: dict = {}
45

56

core/concurrency/worker.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66

77
# Used for lighter calculations where a thread is enough.
88
# Briefly blocking the UI is acceptable.
9+
# TODO: make this truly multi-threaded. instances of this still freeze the UI
910
class WorkerSignals(QObject):
1011
finished = Signal()
1112
error = Signal(tuple)

core/disasm/capstone_disasm.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
from core import logger
99

10-
10+
# todo in-built deobfuscation -> analyze jumps
1111
class CapstoneDisassembler:
1212
def __init__(
1313
self,

core/frida/frida_integration.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
class FridaError(Exception):
1010
pass
1111

12-
12+
# todo fully support Frida
1313
class FridaManager:
1414
def __init__(self):
1515
pass

core/logger.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,8 @@ def _append_to_text_widget(self, text: str, level: int):
6161
color = COLOR_MAPPINGS.get(level, "")
6262
html_text = self._ansi_converter.convert(f"{color}{text}{Style.RESET_ALL}", full=False)
6363

64+
# todo smelly
65+
6466
QMetaObject.invokeMethod(
6567
self._text_widget,
6668
"append",

core/macho/macho.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
from core.constants import MAGIC_64, MAGIC_FAT
22

33

4+
# todo integrate LIEF here
5+
46
def is_macho_file(file_path):
57
with open(file_path, 'rb') as f:
68
magic = int.from_bytes(f.read(4))

ui/tabs/binary_analysis/macho_select_tab.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -142,6 +142,7 @@ def set_file(self, file_path: str):
142142
self._update_config()
143143
self.start_btn.setEnabled(True)
144144

145+
145146
def _update_config(self):
146147
ANALYSIS_CONFIG.options = {
147148
"scan": self.scan_checkbox.isChecked(),

ui/tabs/binary_analysis/scanner_tab.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,8 +44,6 @@ def __init__(self, info_tab=None):
4444
self.tree.setColumnWidth(0, 220)
4545
self.tree.setAlternatingRowColors(True)
4646

47-
# todo add spinner
48-
4947
self.qvBoxLayout.addLayout(header_layout)
5048
self.qvBoxLayout.addWidget(self.tree)
5149

0 commit comments

Comments
 (0)