Remove tabs/whitespace. Add unit test coverage. Add code comments.

Author: webdevel

src/JsonSchema/Constraints/Constraint.php

@@ -37,18 +37,18 @@ public function __construct($checkMode = self::CHECK_MODE_NORMAL, UriRetriever $
         $this->uriRetriever = $uriRetriever;
     }
 
-	/**
-	 * @return UriRetriever $uriRetriever
-	 */
-	public function getUriRetriever()
-	{
-		if (is_null($this->uriRetriever))
-		{
-			$this->setUriRetriever(new UriRetriever);
-		}
-
-		return $this->uriRetriever;
-	}
+    /**
+     * @return UriRetriever $uriRetriever
+     */
+    public function getUriRetriever()
+    {
+        if (is_null($this->uriRetriever))
+        {
+            $this->setUriRetriever(new UriRetriever);
+        }
+
+        return $this->uriRetriever;
+    }
 
     /**
      * @param UriRetriever $uriRetriever
@@ -257,7 +257,7 @@ protected function retrieveUri($uri)
         if (null === $this->uriRetriever) {
             $this->setUriRetriever(new UriRetriever);
         }
-		$jsonSchema = $this->uriRetriever->retrieve($uri);
+        $jsonSchema = $this->uriRetriever->retrieve($uri);
         // TODO validate using schema
         return $jsonSchema;
     }

src/JsonSchema/Constraints/ConstraintInterface.php

@@ -21,29 +21,29 @@ interface ConstraintInterface
      *
      * @return array
      */
-    function getErrors();
+    public function getErrors();
 
     /**
      * adds errors to this validator
      *
      * @param array $errors
      */
-    function addErrors(array $errors);
+    public function addErrors(array $errors);
 
     /**
      * adds an error
      *
      * @param $path
      * @param $message
      */
-    function addError($path, $message);
+    public function addError($path, $message);
 
     /**
      * checks if the validator has not raised errors
      *
      * @return boolean
      */
-    function isValid();
+    public function isValid();
 
     /**
      * invokes the validation of an element
@@ -54,5 +54,5 @@ function isValid();
      * @param mixed $path
      * @param mixed $i
      */
-    function check($value, $schema = null, $path = null, $i = null);
+    public function check($value, $schema = null, $path = null, $i = null);
 }

src/JsonSchema/RefResolver.php

@@ -9,7 +9,7 @@
 
 namespace JsonSchema;
 
-use JsonSchema\Uri\Retrievers\UriRetrieverInterface;
+use JsonSchema\Uri\UriRetriever;
 
 /**
  * Take in an object that's a JSON schema and take care of all $ref references
@@ -201,4 +201,4 @@ public function setUriRetriever(UriRetriever $retriever)
 
         return $this;
     }
-}
+}

src/JsonSchema/Uri/Retrievers/UriRetrieverInterface.php

@@ -16,7 +16,17 @@
  */
 interface UriRetrieverInterface
 {
+    /**
+     * Retrieve a schema from the specified URI
+     * @param string $uri URI that resolves to a JSON schema
+     * @throws \JsonSchema\Exception\ResourceNotFoundException
+     * @return mixed string|null
+     */
     public function retrieve($uri);
 
+    /**
+     * Get media content type
+     * @return string
+     */
     public function getContentType();
 }

tests/JsonSchema/Tests/Constraints/FormatTest.php

@@ -13,6 +13,11 @@
 
 class FormatTest extends BaseTestCase
 {
+    public function setUp()
+    {
+        date_default_timezone_set('UTC');
+    }
+    
     public function testNullThing()
     {
         $validator = new Format();